-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update Gradle build documentation #17408
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Jendrik Johannes <[email protected]>
696801b
to
339d3d5
Compare
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17408 +/- ##
=========================================
Coverage 67.95% 67.95%
Complexity 22341 22341
=========================================
Files 2605 2605
Lines 96887 96887
Branches 10098 10098
=========================================
Hits 65836 65836
Misses 27290 27290
Partials 3761 3761 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you!
Description:
This updates all documentation referring to Gradle and module setup to the current state. The documentation on "Defining modules and dependencies" was moved to https://github.com/hiero-ledger/hiero-gradle-conventions#modules and updated/extended. This PR adds several links to the documentation in that repository that is now the same for other Hiero and Hedera projects.
Related issue(s):
#14255
Notes for reviewer:
I updated the following files so that they are not outdated anymore. Although I think they could use some general revision on the non-Gradle part (for example, integration tests do not exist in this repository at the moment).