Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update Gradle build documentation #17408

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

jjohannes
Copy link
Collaborator

Description:

This updates all documentation referring to Gradle and module setup to the current state. The documentation on "Defining modules and dependencies" was moved to https://github.com/hiero-ledger/hiero-gradle-conventions#modules and updated/extended. This PR adds several links to the documentation in that repository that is now the same for other Hiero and Hedera projects.

Related issue(s):

#14255

Notes for reviewer:

I updated the following files so that they are not outdated anymore. Although I think they could use some general revision on the non-Gradle part (for example, integration tests do not exist in this repository at the moment).

@jjohannes jjohannes added this to the v0.59 milestone Jan 16, 2025
@jjohannes jjohannes self-assigned this Jan 16, 2025
@jjohannes jjohannes requested review from a team as code owners January 16, 2025 11:38
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (6682c10) 96670 69445 71.84%
Head commit (339d3d5) 96670 (+0) 69445 (+0) 71.84% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#17408) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.95%. Comparing base (6682c10) to head (339d3d5).
Report is 17 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main   #17408   +/-   ##
=========================================
  Coverage     67.95%   67.95%           
  Complexity    22341    22341           
=========================================
  Files          2605     2605           
  Lines         96887    96887           
  Branches      10098    10098           
=========================================
  Hits          65836    65836           
  Misses        27290    27290           
  Partials       3761     3761           

Impacted file tree graph

Copy link
Contributor

@andrewb1269hg andrewb1269hg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Contributor

@anthony-swirldslabs anthony-swirldslabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants