-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add factory method for StateSignatureTransaction #17447
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Michael Heinrichs <[email protected]>
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17447 +/- ##
============================================
+ Coverage 68.91% 68.98% +0.06%
- Complexity 22667 22770 +103
============================================
Files 2613 2619 +6
Lines 97892 98282 +390
Branches 10156 10184 +28
============================================
+ Hits 67463 67796 +333
- Misses 26613 26658 +45
- Partials 3816 3828 +12
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @netopyr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @netopyr
final var instant = appContext.instantSource().instant(); | ||
final var nodeAccountID = appContext.selfNodeInfoSupplier().get().accountId(); | ||
|
||
final var transactionValidStart = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Afaict the transactionValidDuration
and transactionID#transactionValidStart
fields have only very minimal verification here during PreHandleWorkflow
and we could set them here to,
Duration.DEFAULT
Timestamp.DEFAULT
respectively. Unless we want to change that, I would suggest using these DEFAULT
values to (1) save a few bytes and (2) avoid implying to the reader taht these transactions get deeper validation downstream.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, good point. For some reason, I was convinced we would check if the time interval was valid. But we cannot do it at this point, of course. I will update the code. Thanks!
Signed-off-by: Michael Heinrichs <[email protected]>
4aabb91
Description:
This PR adds an implementation of
SwirldMain.encodeSystemTransaction()
inHedera
.Related issue(s):
Fixes #17073
Notes for reviewer:
Checklist