Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: HIP-904 Additional e2e test cases where sender is a contract #17459

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

stoyanov-st
Copy link
Contributor

@stoyanov-st stoyanov-st commented Jan 21, 2025

Description:
Adding some test cases for HIP-904 where sender is a contract

Related issue(s):

Fixes #16262
Fixes #16263
Fixes #16264
Fixes #16265
Fixes #16266
Fixes #16267
Fixes #16268

Notes for reviewer:
This PR is owned and authored by @bubo

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@stoyanov-st stoyanov-st added this to the v0.59 milestone Jan 21, 2025
@stoyanov-st stoyanov-st self-assigned this Jan 21, 2025
@stoyanov-st stoyanov-st requested review from a team as code owners January 21, 2025 08:51
@stoyanov-st stoyanov-st requested a review from netopyr January 21, 2025 08:51
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (3e8fa1f) 97675 71128 72.82%
Head commit (5c1c084) 97675 (+0) 71128 (+0) 72.82% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#17459) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.91%. Comparing base (3e8fa1f) to head (5c1c084).
Report is 5 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main   #17459   +/-   ##
=========================================
  Coverage     68.91%   68.91%           
- Complexity    22667    22668    +1     
=========================================
  Files          2613     2613           
  Lines         97892    97892           
  Branches      10156    10156           
=========================================
  Hits          67463    67463           
  Misses        26613    26613           
  Partials       3816     3816           

Impacted file tree graph

Copy link
Member

@lukelee-sl lukelee-sl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for adding these tests.

@stoyanov-st stoyanov-st merged commit fadab3b into main Jan 22, 2025
74 of 76 checks passed
@stoyanov-st stoyanov-st deleted the hip-904-additional-e2e-tests branch January 22, 2025 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants