Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 17467: Back out changes for 15448 from release 0.58 #17473

Open
wants to merge 1 commit into
base: release/0.58
Choose a base branch
from

Conversation

artemananiev
Copy link
Member

Fix summary: changes for #15448 are partially reverted.

Fixes: #17467
Signed-off-by: Artem Ananev [email protected]

@artemananiev artemananiev added this to the v0.58 milestone Jan 21, 2025
@artemananiev artemananiev self-assigned this Jan 21, 2025
@artemananiev artemananiev requested review from a team as code owners January 21, 2025 20:23
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 93.18182% with 3 lines in your changes missing coverage. Please review.

Project coverage is 64.32%. Comparing base (ad53b0c) to head (a48110e).
Report is 1 commits behind head on release/0.58.

Files with missing lines Patch % Lines
...ds/virtualmap/internal/cache/VirtualNodeCache.java 88.46% 0 Missing and 3 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##             release/0.58   #17473      +/-   ##
==================================================
- Coverage           64.35%   64.32%   -0.03%     
+ Complexity          20914    20884      -30     
==================================================
  Files                2549     2549              
  Lines               96049    95972      -77     
  Branches            10048    10032      -16     
==================================================
- Hits                61812    61736      -76     
- Misses              30601    30612      +11     
+ Partials             3636     3624      -12     
Files with missing lines Coverage Δ
...ds/virtualmap/internal/merkle/VirtualRootNode.java 57.18% <100.00%> (-0.35%) ⬇️
.../virtualmap/internal/pipeline/VirtualPipeline.java 57.70% <100.00%> (-2.30%) ⬇️
...rlds/virtualmap/internal/pipeline/VirtualRoot.java 0.00% <ø> (ø)
...ds/virtualmap/internal/cache/VirtualNodeCache.java 78.70% <88.46%> (+1.81%) ⬆️

... and 14 files with indirect coverage changes

Impacted file tree graph

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.04% (target: -1.00%) 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (ad53b0c) 95812 65256 68.11%
Head commit (a48110e) 95735 (-77) 65168 (-88) 68.07% (-0.04%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#17473) 44 44 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants