This repository has been archived by the owner on Sep 28, 2021. It is now read-only.
Feature/add nomad token support #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes Serhii Shuiar seems not to be a GitHub user. Have you signed the CLA already but the status is still pending? Recheck it. |
drewbailey
reviewed
Dec 9, 2019
| @@ -136,6 +136,9 @@ def request(verb, path, data = {}, headers = {}) | |||
| # Get a list of headers | |||
| headers = DEFAULT_HEADERS.merge(headers) | |||
|
|
|||
| # Dynamically read Nomad ACL token | |||
| headers = headers.merge({"X-Nomad-Token" => nomad_token}) | |||
There was a problem hiding this comment.
Do you mind guarding this so if nomad_token is nil the header is excluded.
drewbailey
reviewed
Dec 9, 2019
| end | ||
| end | ||
|
|
||
|
|
drewbailey
reviewed
Dec 9, 2019
| @@ -31,7 +31,7 @@ class Response | |||
|
|
|||
| # Parses the value as a string, converting "" to nil (go compat). | |||
| string_as_nil: ->(item) { | |||
| if item.nil? || item.strip.empty? | |||
| if item.nil? || item.to_s.strip.empty? | |||
drewbailey
suggested changes
Dec 9, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.