-
Notifications
You must be signed in to change notification settings - Fork 700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
attempt to use local actions #10503
base: master
Are you sure you want to change the base?
attempt to use local actions #10503
Conversation
8565a7c
to
501bde6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing, thanks!
But in a follow-up, we really need to sweep the less-relevant comments (like |
They're not entirely pointless: they mark the (IMO unnecessary except that GHA is stupid) duplications. |
well, it's too subtle. I'd appreciate something less playful and more direct. E.g. for the matrix, |
At this point I do not recommend merging this unless you have someone, preferably several someones, who understand it; otherwise your bus factor situation is looking pretty dire. If necessary I can expand the prerelease jobs out to full form and submit those separately, as they're the most urgent part of this and I don't want to leave you in a bad situation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's put this PR away for the moment
Ehhh, GitHub Actions stuff is kinda always like that. It's usually not too miserable to make small tweaks to, but changes in design goals require rearchitecting, as I think you're running into with this! I haven't read over this with eagle eyes but it looks largely fine to me. A couple notes:
|
32f70a0
to
c262de2
Compare
c262de2
to
a4659da
Compare
a4659da
to
08450d4
Compare
Dammit, GitHub, this |
61e315d
to
66bd645
Compare
Installed |
66bd645
to
a7dd677
Compare
Sigh. NTS: GitHub's insistence on turning |
Extremely experimental, and with all the limitations and restrictions I keep finding in GitHub Actions it'll probably fail in the messiest way it can. At present this is incomplete but sufficient to see if this has any chance of working to begin with. If it somehow does, I'll look into abstracting out the other sub-jobs, then making an overnight validate for Tier 2 platforms and probably a prerelease job (which would fix the recently revealed problem where if there is no need to rebase on merge, no prerelease is made).
a7dd677
to
f326a33
Compare
The tests suddenly aren't finding the caches from the build step. This could be really bad. |
GitHub has started aggressively pruning caches; we went from around 300GB in use to 25GB, which means they can't be used as shared state between the build and test stages any more. Will rewrite to use artifacts to pass the important parts around, but that will have its own limits and may have its own problems. |
Extremely experimental, and with all the limitations and restrictions I keep finding in GitHub Actions it'll probably fail in the messiest way it can.
At present this is incomplete but sufficient to see if this has any chance of working to begin with. If it somehow does, I'll look into abstracting out the other sub-jobs, then making an overnight validate for Tier 2 platforms and probably a prerelease job (which would fix the recently revealed problem where if there is no need to rebase on merge, no prerelease is made).
Template B: This PR does not modify behaviour or interface
E.g. the PR only touches documentation or tests, does refactorings, etc.
Include the following checklist in your PR:
Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions).(No point in backporting, as even the LTS prerelease part has to live onmaster
.)