Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

try to figure out why static builds lack git info #10693

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

try to figure out why static builds lack git info #10693

wants to merge 3 commits into from

Conversation

geekosaur
Copy link
Collaborator

Please read Github PR Conventions and then fill in one of these two templates.

Template B: This PR does not modify behaviour or interface

E.g. the PR only touches documentation or tests, does refactorings, etc.

Include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions).

@geekosaur geekosaur force-pushed the static-git-info branch 2 times, most recently from a186c91 to a9c0a0c Compare December 31, 2024 14:57
ulysses4ever
ulysses4ever approved these changes Dec 31, 2024
View reviewed changes
Copy link
Collaborator

@ulysses4ever ulysses4ever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the interest of experimenting, this could be fast-tracked, I hope.

@geekosaur geekosaur linked an issue Dec 31, 2024 that may be closed by this pull request
Git SHA isn't shown on cabal-head #10691
Open
@ulysses4ever
Copy link
Collaborator

If it's "ready for review", maybe un-draft it too?

@ulysses4ever ulysses4ever requested a review from Mikolaj December 31, 2024 15:19
@geekosaur
Copy link
Collaborator Author

Haven't yet modified the git stuff to degrade gracefully on lack of git info yet; been focused on trying to make the Alpine job provide it.

@geekosaur geekosaur marked this pull request as ready for review December 31, 2024 15:39
@ulysses4ever
Copy link
Collaborator

All right, it's up to you, of course. In my mind, these were separate issues. But I guess it may be more ergonomic to kill two birds with one PR!

@geekosaur
amend! try to figure out why static builds lack git info
78f5dc5 
try to figure out why static builds lack git info
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ulysses4ever ulysses4ever ulysses4ever approved these changes

@Mikolaj Mikolaj Awaiting requested review from Mikolaj

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
attention: needs-review priority: high 🔥
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Git SHA isn't shown on cabal-head
2 participants
@geekosaur @ulysses4ever