Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MIDI_CIN_NOTE_ON definition transposed with MIDI_CIN_NOTE_OFF #1920

Merged
merged 1 commit into from
Apr 18, 2023

Conversation

mikee47
Copy link

@mikee47 mikee47 commented Feb 22, 2023

The definitions for MIDI_CIN_NOTE_ON and MIDI_CIN_NOTE_OFF are transposed in the header file.

@mikee47
Copy link
Author

mikee47 commented Feb 22, 2023

I note this is also in #1627

@rppicomidi
Copy link
Contributor

@hathach The change @mikee47 submitted is correct per the MIDI Class spec. 0x8 is Note Off. 0x9 is Note On. I pasted the table from the USB spec for your convenience.
image

@hathach
Copy link
Owner

hathach commented Apr 18, 2023

@hathach The change @mikee47 submitted is correct per the MIDI Class spec. 0x8 is Note Off. 0x9 is Note On. I pasted the table from the USB spec for your convenience. image

thank you, I am actually planning to review your midi host, but couldn't manage the time. I gues we could merge this quick fix first.

Copy link
Owner

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@hathach hathach merged commit c3a60ed into hathach:master Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants