Skip to content

Commit

Permalink
Merge pull request #2050 from hbz/1991-newspaperAsPeriodical
Browse files Browse the repository at this point in the history
Tag type:newspaper as type:periodical too #1991
  • Loading branch information
TobiasNx authored Aug 12, 2024
2 parents 6576076 + d23ffc0 commit 3e15957
Show file tree
Hide file tree
Showing 7 changed files with 10 additions and 7 deletions.
5 changes: 4 additions & 1 deletion src/main/resources/alma/fix/mediumAndType.fix
Original file line number Diff line number Diff line change
Expand Up @@ -529,15 +529,18 @@ unless any_match("@300a_mainExtend", ".*(CD|Schallpl).*")
end
end

# type: "Newspaper"
# type: "Newspaper" are always Periodicals too


if any_match("@leaderTyp+008", "(Continuing Resources)(.{21})n.*") # Pos21
add_field("type[].$append","Newspaper")
add_field("type[].$append","Periodical")
elsif any_match("006", "^s(.{3})n.*") # Pos00+04
add_field("type[].$append","Newspaper")
add_field("type[].$append","Periodical")
elsif any_match("natureOfContent[].*.label", ".*Zeitung.*")
add_field("type[].$append", "Newspaper")
add_field("type[].$append","Periodical")
end

# type: "Standard"
Expand Down
2 changes: 1 addition & 1 deletion src/test/resources/alma-fix/990054089950206441.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"@context" : "http://lobid.org/resources/context.jsonld",
"id" : "http://lobid.org/resources/990054089950206441#!",
"type" : [ "BibliographicResource", "Newspaper" ],
"type" : [ "BibliographicResource", "Newspaper", "Periodical" ],
"medium" : [ {
"label" : "Print",
"id" : "http://rdaregistry.info/termList/RDAproductionMethod/1010"
Expand Down
2 changes: 1 addition & 1 deletion src/test/resources/alma-fix/990103770440206441.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"@context" : "http://lobid.org/resources/context.jsonld",
"id" : "http://lobid.org/resources/990103770440206441#!",
"type" : [ "BibliographicResource", "Newspaper" ],
"type" : [ "BibliographicResource", "Newspaper", "Periodical" ],
"medium" : [ {
"label" : "Print",
"id" : "http://rdaregistry.info/termList/RDAproductionMethod/1010"
Expand Down
2 changes: 1 addition & 1 deletion src/test/resources/alma-fix/990108740950206441.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"@context" : "http://lobid.org/resources/context.jsonld",
"id" : "http://lobid.org/resources/990108740950206441#!",
"type" : [ "BibliographicResource", "Newspaper" ],
"type" : [ "BibliographicResource", "Newspaper", "Periodical" ],
"medium" : [ {
"label" : "Print",
"id" : "http://rdaregistry.info/termList/RDAproductionMethod/1010"
Expand Down
2 changes: 1 addition & 1 deletion src/test/resources/alma-fix/990136041660206441.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"@context" : "http://lobid.org/resources/context.jsonld",
"id" : "http://lobid.org/resources/990136041660206441#!",
"type" : [ "BibliographicResource", "Newspaper" ],
"type" : [ "BibliographicResource", "Newspaper", "Periodical" ],
"medium" : [ {
"label" : "Print",
"id" : "http://rdaregistry.info/termList/RDAproductionMethod/1010"
Expand Down
2 changes: 1 addition & 1 deletion src/test/resources/alma-fix/990196925330206441.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"@context" : "http://lobid.org/resources/context.jsonld",
"id" : "http://lobid.org/resources/990196925330206441#!",
"type" : [ "BibliographicResource", "Newspaper" ],
"type" : [ "BibliographicResource", "Newspaper", "Periodical" ],
"medium" : [ {
"label" : "Print",
"id" : "http://rdaregistry.info/termList/RDAproductionMethod/1010"
Expand Down
2 changes: 1 addition & 1 deletion src/test/resources/alma-fix/990197023370206441.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"@context" : "http://lobid.org/resources/context.jsonld",
"id" : "http://lobid.org/resources/990197023370206441#!",
"type" : [ "BibliographicResource", "Newspaper" ],
"type" : [ "BibliographicResource", "Newspaper", "Periodical" ],
"medium" : [ {
"label" : "Datenträger",
"id" : "http://rdaregistry.info/termList/RDAMediaType/1003"
Expand Down

0 comments on commit 3e15957

Please sign in to comment.