1017 add notations to spatial objects #1020
Conversation
- create morph map from nwbib-skos-file automatically - allow notations to be a number greater 99 - use other delimiter than commata (because this is sometimes part of the data) - update morph to create nice label for wikidata QIds - update test See #1017.
dr0i
requested review from
acka47 and
fsteeg
and removed request for
fsteeg
|
@acka47 ping to review |
|
In #1017 (comment) @acka47 informed that the nwbib-spatial.ttl was updated. Thus, this PR has to be updated. |
Every time the file in lobid-vocabs is updated the nwbib-spatial.tsv has to be also updated. This updating process is automatically done every time before the geo-nwbib-index is rebuild. See #1017.
|
Looks like a PR from me with lots of automatic formatting edits in the morph. ;-) However, everything is fine: +1 |
Did the formatting in a commit of its own to be able to review the substantial logic. |
|
Deployed to production. |
|
Ah, now I forgot to assign the review for @fsteeg . |
Sorry, I didn't notice that. I take my comment back. |
|
No problem, for one the formatting is not a part of the issue and for two you reminded me to open a new issue to solve the formatting problem. So, good thing came out of it :) |
| LOG.info("going to load 'notation' from " + NOTATION_CSV_FN + "..."); | ||
| String line = null; | ||
| try { | ||
| lineReader = new BufferedReader(new FileReader(NOTATION_CSV_FN)); |
There was a problem hiding this comment.
In case you didn't know, there's a new-ish way of reading lines that I like since it's very concise. Basic idea:
for (String line : Files.readAllLines(Paths.get(NOTATION_CSV_FN))) {
String[] nwbibSpatialTsv = line.split("\\|");
//...
}May be useful for the next time or something.
|
+1 (I don't see a way to officially approve, maybe because it's closed) |
See #1017 .