Alma marc21 xml to lobid json #1094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add dependency to have access to XmlRootElement - format a bit
Based on morphs provided by @blackwinter, see https://github.com/hbz/limetrans/compare/alma See #1089.
- update metamorph.xsd - allow date to be parsed as 4 digit or 8 digit
…almaMarc21XmlToLobidJson
- validate Alma data - move "schemas" into "resources"
- remove some more test data - remove encoding for ByteArrayOutputStream to avoid error when running mvn via console
- fix item id
- make id string - add gndIdentifier - fix role label
- update tests
This makes it more overt for the normal user when postprocessing the output, e.g. using "grep", because now you get what you see.
fsteeg
approved these changes
Dec 14, 2020
There was a problem hiding this comment.
Looks good on the code level as far as I can tell. Just three things I noticed:
- Formatting in the Morph files is often inconsistent, perhaps some automatic formatting and/or checks might be useful here?
- I'm surprised to see metamorph.xsd as part of the repo and the diff, but I think you talked about that in a recent standup?
- If I understand correctly, the JSON validation via script is not part of the build? But we'll get that anyway with Move and integrate JsonValidator metafacture/metafacture-core#347
|
Closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial transformation of Alma Marc21 XML to lobid JSON-LD.
See #1089.