Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Spiegel as testfile #1895

Merged
merged 5 commits into from
May 16, 2024
Merged

Add Spiegel as testfile #1895

merged 5 commits into from
May 16, 2024

Conversation

TobiasNx
Copy link
Contributor

@TobiasNx TobiasNx commented Sep 18, 2023

Testfile for #1830

@TobiasNx TobiasNx force-pushed the spiegelNotBreakingAnymore branch from 2027bfe to b666ac1 Compare September 18, 2023 12:19
@TobiasNx TobiasNx changed the title Test Spiegel again Add Spiegel as testfile Sep 18, 2023
@TobiasNx TobiasNx marked this pull request as ready for review September 18, 2023 12:20
@TobiasNx
Copy link
Contributor Author

Wenn running:
~/git/lobid-resources/src/test/resources/alma-fix$ bash updateAlmaTestFiles.sh 990054089950206441
the test file can be added.

But when running afterwards the following it breaks:

~/git/lobid-resources$ $ mvn clean install -DskipTests=false -DgenerateTestData=true
[INFO] Scanning for projects...
[INFO] 
[INFO] ---------------------< org.lobid:lobid-resources >----------------------
[INFO] Building lobid-resources 1.0.1-SNAPSHOT
[INFO] --------------------------------[ jar ]---------------------------------
[INFO] 
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @ lobid-resources ---
[INFO] Deleting /home/tobias/git/lobid-resources/target
[INFO] 
[INFO] --- maven-resources-plugin:2.6:resources (default-resources) @ lobid-resources ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 35 resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.3:compile (default-compile) @ lobid-resources ---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 15 source files to /home/tobias/git/lobid-resources/target/classes
[WARNING] system modules path not set in conjunction with -source 11
[INFO] /home/tobias/git/lobid-resources/src/main/java/org/lobid/resources/EtikettJson.java: Some input files use unchecked or unsafe operations.
[INFO] /home/tobias/git/lobid-resources/src/main/java/org/lobid/resources/EtikettJson.java: Recompile with -Xlint:unchecked for details.
[INFO] 
[INFO] --- maven-resources-plugin:2.6:testResources (default-testResources) @ lobid-resources ---
[INFO] Using 'UTF-8' encoding to copy filtered resources.
[INFO] Copying 540 resources
[INFO] 
[INFO] --- maven-compiler-plugin:3.3:testCompile (default-testCompile) @ lobid-resources ---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 3 source files to /home/tobias/git/lobid-resources/target/test-classes
[WARNING] system modules path not set in conjunction with -source 11
[INFO] 
[INFO] --- maven-surefire-plugin:2.19.1:test (default-test) @ lobid-resources ---

-------------------------------------------------------
 T E S T S
-------------------------------------------------------
Running UnitTests
SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
Tests run: 2, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 17.445 sec <<< FAILURE! - in UnitTests
transformFile(org.lobid.resources.AlmaMarc21XmlToLobidJsonMetafixTest)  Time elapsed: 16.842 sec  <<< ERROR!
java.lang.OutOfMemoryError: Java heap space


Results :

Tests in error: 
  AlmaMarc21XmlToLobidJsonMetafixTest.transformFile » OutOfMemory Java heap spac...

Tests run: 2, Failures: 0, Errors: 1, Skipped: 0

[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  22.839 s
[INFO] Finished at: 2024-04-19T15:36:28+02:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test (default-test) on project lobid-resources: There are test failures.
[ERROR] 
[ERROR] Please refer to /home/tobias/git/lobid-resources/target/surefire-reports for the individual test results.
[ERROR] -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

@TobiasNx
Copy link
Contributor Author

@dr0i how can I increase the heapsize to get this testfile?

dr0i added a commit that referenced this pull request May 14, 2024
This makes the tests run by avoiding "java.lang.OutOfMemoryError: Java heap space".
dr0i added a commit that referenced this pull request May 14, 2024
This makes the tests run by avoiding "java.lang.OutOfMemoryError: Java heap space".
@dr0i dr0i force-pushed the spiegelNotBreakingAnymore branch from ff1d31e to 8d8cd13 Compare May 14, 2024 15:36
dr0i added a commit that referenced this pull request May 14, 2024
This makes the tests run by avoiding "java.lang.OutOfMemoryError: Java heap space".
@dr0i dr0i force-pushed the spiegelNotBreakingAnymore branch from 8d8cd13 to 9e16a44 Compare May 14, 2024 16:09
dr0i added a commit that referenced this pull request May 14, 2024
This makes the tests run by avoiding "java.lang.OutOfMemoryError: Java heap space".
@dr0i dr0i force-pushed the spiegelNotBreakingAnymore branch from 9e16a44 to 96861aa Compare May 14, 2024 16:10
dr0i added a commit that referenced this pull request May 14, 2024
This makes the tests run by avoiding "java.lang.OutOfMemoryError: Java heap space".
@dr0i dr0i force-pushed the spiegelNotBreakingAnymore branch from 96861aa to 2dd4837 Compare May 14, 2024 16:15
dr0i added a commit that referenced this pull request May 14, 2024
-  bump java version to 11

This makes the tests run by avoiding "java.lang.OutOfMemoryError: Java heap space".
@dr0i dr0i force-pushed the spiegelNotBreakingAnymore branch from 2dd4837 to 09d3358 Compare May 14, 2024 16:21
dr0i added a commit that referenced this pull request May 14, 2024
-  bump java version to 11

This makes the tests run by avoiding "java.lang.OutOfMemoryError: Java heap space".
@dr0i dr0i force-pushed the spiegelNotBreakingAnymore branch from 09d3358 to 56d0ff4 Compare May 14, 2024 16:29
@dr0i
Copy link
Member

dr0i commented May 14, 2024

I've increased Java's memory to 768 MB , which seems to be sufficient at least.
Now there are some other errors, the "usual suspects" , which you can fix.

dr0i and others added 2 commits May 15, 2024 09:39
-  bump java version to 11

This makes the tests run by avoiding "java.lang.OutOfMemoryError: Java heap space".
@TobiasNx TobiasNx force-pushed the spiegelNotBreakingAnymore branch from 56d0ff4 to 66782bb Compare May 15, 2024 08:01
@TobiasNx
Copy link
Contributor Author

When testing a new version of this record, it seems that it still runs into an error when executing: mvn clean install -DskipTests=false -DgenerateTestData=true

I saw that I found a solution last year in another branch. I had to increase the heap size in the pom.xml too.
@dr0i can you have a look if this is okay?

@dr0i
Copy link
Member

dr0i commented May 16, 2024

I saw that I found a solution last year in another branch.

Can you share a link to this?

66782bb : please don't change formatting for a diff is useless then - I can't see what you have changed in essence.

@TobiasNx
Copy link
Contributor Author

I saw that I found a solution last year in another branch.

Can you share a link to this?

66782bb : please don't change formatting for a diff is useless then - I can't see what you have changed in essence.

This was the old commit, in an unused branch: d77e9bf

I also will set the formatting back in an additional commit.

@TobiasNx TobiasNx force-pushed the spiegelNotBreakingAnymore branch from 5e17220 to cacea8f Compare May 16, 2024 10:17
@TobiasNx TobiasNx force-pushed the spiegelNotBreakingAnymore branch from cacea8f to 3500db5 Compare May 16, 2024 11:05
@TobiasNx
Copy link
Contributor Author

I separated the commits for formatting, since it seems to be wrong, and the change of the heap.

@TobiasNx TobiasNx requested a review from dr0i May 16, 2024 11:07
@dr0i dr0i merged commit 51907ed into master May 16, 2024
1 check passed
@dr0i
Copy link
Member

dr0i commented May 16, 2024

+1

@dr0i dr0i deleted the spiegelNotBreakingAnymore branch May 16, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants