Fix contribution transformation #1954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dr0i
changed the title
|
+1 |
|
Will be deployed next Monday. |
dr0i
reviewed
Apr 2, 2024
| "startDate" : "1929", | ||
| "type" : [ "PublicationEvent" ], | ||
| "location" : [ "New York :" ], | ||
| "publishedBy" : [ "Inquiry" ] |
There was a problem hiding this comment.
Strange - this build succesfully with GitHub actions first - but after merging it fails because it expects [ "New York" ] (i.e. without colon).
There was a problem hiding this comment.
Okay it seems that the commit was not okay, I did no good review here.
For an better approach we should add the new test file in a separate first commit, if there is none yet.
In the later commit we should add the code changes and include the changes in the test to highlight the reaction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1952.