Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix extent for repeated 300 with multiple Subfields #1974

Merged
merged 2 commits into from
Mar 21, 2024

Conversation

maipet
Copy link
Contributor

@maipet maipet commented Mar 21, 2024

Adjust replacement of brackets

@maipet maipet requested a review from dr0i March 21, 2024 10:33
@maipet
Copy link
Contributor Author

maipet commented Mar 21, 2024

I didn't get it 100%, maybe @TobiasNx can help?

@dr0i
Copy link
Member

dr0i commented Mar 21, 2024

Could solve it by print-debugging - i.e. insert some identifiable messages in (here) replace functions and let the tests rebuild the data anew with mvn clean install -DskipTests=false -DgenerateTestData=true. Then git diff and search for the messages. If you know which statements should/could provide the missing bracket (or which variable is involved and trace that variable) it's not so far from try-and-error-until-resolved.

@dr0i dr0i merged commit a308ef9 into master Mar 21, 2024
1 check passed
@dr0i dr0i deleted the FixExtentForRepeated300 branch March 21, 2024 13:14
@TobiasNx
Copy link
Contributor

I did not find a corresponding issue for this. We should add issues for upcoming changes in the scrips if they result from errors to better document our progress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants