Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1977-duplicateH52 #1978

Merged
merged 4 commits into from
Apr 25, 2024
Merged

1977-duplicateH52 #1978

merged 4 commits into from
Apr 25, 2024

Conversation

TobiasNx
Copy link
Contributor

Fix reported error #1977

@TobiasNx TobiasNx requested a review from dr0i March 27, 2024 15:21
@dr0i
Copy link
Member

dr0i commented Apr 16, 2024

In your first commit you have only added the XML , not the resulted JSON. In the second commit you then added the JSON. Thus no diff is possible, which was your intention I assume.
I will add the JSON to the first commit and force push so we can better see what your Fix changes.

@TobiasNx
Copy link
Contributor Author

Nope! This is intentional, since the test breaks!!! The second commit resolves this.

@dr0i
Copy link
Member

dr0i commented Apr 16, 2024

Yeah I see - it's not even possible to generate that JSON ;)

@dr0i
Copy link
Member

dr0i commented Apr 16, 2024

There are conflicts - can you resolve these @TobiasNx ? I also wouldn't mind if you rebase and force push.

@dr0i dr0i assigned TobiasNx and unassigned dr0i Apr 16, 2024
@TobiasNx
Copy link
Contributor Author

I merged the master and resolved the conflicts. But now the tests seem to fail.

@dr0i
Copy link
Member

dr0i commented Apr 18, 2024

Build and test with Play fails. Have a look at the README (search for play) . If that is not sufficiently helpful we should talk together and you would bring the README to perfection :)

@TobiasNx TobiasNx marked this pull request as ready for review April 19, 2024 12:32
@TobiasNx TobiasNx assigned dr0i and unassigned TobiasNx Apr 25, 2024
@TobiasNx
Copy link
Contributor Author

@dr0i fixed it.

@dr0i dr0i merged commit 0a376ff into master Apr 25, 2024
1 check passed
@dr0i dr0i deleted the 1977-duplicateH52 branch April 25, 2024 11:40
@dr0i
Copy link
Member

dr0i commented Apr 25, 2024

Good :)
Will be deployed next Monday. Closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants