-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1977-duplicateH52 #1978
1977-duplicateH52 #1978
Conversation
In your first commit you have only added the XML , not the resulted JSON. In the second commit you then added the JSON. Thus no diff is possible, which was your intention I assume. |
Nope! This is intentional, since the test breaks!!! The second commit resolves this. |
Yeah I see - it's not even possible to generate that JSON ;) |
There are conflicts - can you resolve these @TobiasNx ? I also wouldn't mind if you rebase and force push. |
I merged the master and resolved the conflicts. But now the tests seem to fail. |
|
@dr0i fixed it. |
Good :) |
Fix reported error #1977