2034-newAdjestUrnRegex #2043
Merged
2034-newAdjestUrnRegex #2043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I try to catch all URN Links except those repository links that are have a urn/urn pattern since they are not resolver links: http://digital.ub.uni-duesseldorf.de/urn/urn:nbn:de:hbz:061:1-249692 or https://sammlungen.ulb.uni-muenster.de/urn/urn:nbn:de:hbz:6-85659520092
Closed
maipet
approved these changes
Aug 7, 2024
blackwinter
reviewed
Aug 7, 2024
According to @blackwinter suggestion: #2043 (comment)
|
@blackwinter since you became a reviewer by commenting, your approval is still pending. |
|
But it's not required, is it? I'm just offering suggestions. Feel free to deal with them however you see fit. If you're asking for approval, though, I'm inclinded to suggest that you adjust the other regexp as well. |
Feel free to suggest the change for the other one, always good to improve code. |
blackwinter
reviewed
Aug 8, 2024
Co-authored-by: Jens Wille <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2034
Replaces #2035
This PR tries to catch all URN resolver links not just nbn from 865.
It uses the URNs from 024 as fallback if no 865 links with URN are provided.
Also it changes the nbn links to org when creating them as fallback.