Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude metafix' log4j12 dependency to fix logging #2055

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Conversation

dr0i
Copy link
Member

@dr0i dr0i commented Aug 19, 2024

Fixes #2042.

@dr0i dr0i requested a review from TobiasNx August 19, 2024 13:58
@dr0i dr0i added the dependencies Pull requests that update a dependency file label Aug 19, 2024
@TobiasNx
Copy link
Contributor

TobiasNx commented Aug 30, 2024

Didn't this state how many records were transformed at the end? I am not sure.

Running UnitTests
[main] INFO de.hbz.lobid.helper.EtikettMaker - use labels directory: /home/tobias/git/lobid-resources/target/classes/labels
[main] INFO de.hbz.lobid.helper.EtikettMaker - Create labels....
[main] INFO de.hbz.lobid.helper.EtikettMaker - ...succeed!
[main] INFO de.hbz.lobid.helper.EtikettMaker - Writing context file ...
[main] INFO de.hbz.lobid.helper.EtikettMaker - ... done writing context file to web/conf/context.jsonld.
[main] INFO org.lobid.resources.AlmaMarc21XmlToLobidJsonMetafixTest - Starting transforming File
[main] INFO de.hbz.lobid.helper.EtikettMaker - use labels directory: /home/tobias/git/lobid-resources/target/classes/labels
[main] INFO de.hbz.lobid.helper.EtikettMaker - Create labels....
[main] INFO de.hbz.lobid.helper.EtikettMaker - ...succeed!
[main] INFO de.hbz.lobid.helper.EtikettMaker - Writing context file ...
[main] INFO de.hbz.lobid.helper.EtikettMaker - ... done writing context file to web/conf/context.jsonld.
[main] INFO org.metafacture.monitoring.StreamBatchLogger - records processed: 10
[main] INFO org.metafacture.monitoring.StreamBatchLogger - records processed: 20
[main] INFO org.metafacture.monitoring.StreamBatchLogger - records processed: 30
[main] INFO org.metafacture.monitoring.StreamBatchLogger - records processed: 40
[main] INFO org.metafacture.monitoring.StreamBatchLogger - records processed: 50
[main] INFO org.metafacture.monitoring.StreamBatchLogger - records processed: 60
[main] INFO org.metafacture.monitoring.StreamBatchLogger - records processed: 70
[main] INFO org.metafacture.monitoring.StreamBatchLogger - records processed: 80
[main] INFO org.metafacture.monitoring.StreamBatchLogger - records processed: 90
[main] INFO org.metafacture.monitoring.StreamBatchLogger - records processed: 100
[main] INFO org.metafacture.monitoring.StreamBatchLogger - records processed: 110
[main] INFO org.metafacture.monitoring.StreamBatchLogger - records processed: 120
[main] INFO org.metafacture.monitoring.StreamBatchLogger - records processed: 130
[main] INFO org.metafacture.monitoring.StreamBatchLogger - records processed: 140
[main] INFO org.metafacture.monitoring.StreamBatchLogger - records processed: 150
[main] INFO org.metafacture.monitoring.StreamBatchLogger - records processed: 152
2024-08-30 09:00:59 INFO [org.elasticsearch.node.Node.<init>(Node.java:254)] - initializing ...
2024-08-30 09:00:59 INFO [org.elasticsearch.env.NodeEnvironment.maybeLogHeapDetails(NodeEnvironment.java:403)] - heap size [1.5gb], compressed ordinary object pointers [true]
2024-08-30 09:00:59 INFO [org.elasticsearch.node.Node.<init>(Node.java:282)] - node name [testNodeCgRvk], node ID [EjlVGLrVQj-ggfa4xkZaGw]
2024-08-30 09:00:59 INFO [org.elasticsearch.node.Node.<init>(Node.java:286)] - version[5.6.3], pid[140043], build[1a2f265/2017-10-06T20:33:39.012Z], OS[Linux/6.8.0-41-generic/amd64], JVM[Ubuntu/OpenJDK 64-Bit Server VM/17.0.12/17.0.12+7-Ubuntu-1ubuntu224.04]
2024-08-30 09:00:59 INFO [org.elasticsearch.node.Node.<init>(Node.java:299)] - JVM arguments [-Xmx1536m]
2024-08-30 09:00:59 INFO [org.elasticsearch.plugins.PluginsService.logPluginInfo(PluginsService.java:175)] - no modules loaded
2024-08-30 09:00:59 INFO [org.elasticsearch.plugins.PluginsService.logPluginInfo(PluginsService.java:178)] - loaded plugin [org.elasticsearch.transport.Netty4Plugin]
2024-08-30 09:01:02 INFO [org.elasticsearch.discovery.DiscoveryModule.<init>(DiscoveryModule.java:99)] - using discovery type [single-node]
2024-08-30 09:01:03 INFO [org.elasticsearch.node.Node.<init>(Node.java:515)] - initialized
2024-08-30 09:01:03 INFO [org.elasticsearch.node.Node.start(Node.java:656)] - starting ...
2024-08-30 09:01:03 INFO [org.elasticsearch.transport.TransportService.doStart(TransportService.java:212)] - publish_address {127.0.0.1:19201}, bound_addresses {[::1]:19201}, {127.0.0.1:19201}
2024-08-30 09:01:03 INFO [org.elasticsearch.cluster.service.ClusterService.publishAndApplyChanges(ClusterService.java:725)] - new_master {testNodeCgRvk}{EjlVGLrVQj-ggfa4xkZaGw}{E9Ysac5MQ36ZMiaxk302Pw}{127.0.0.1}{127.0.0.1:19201}, reason: single-node-start-initial-join[{testNodeCgRvk}{EjlVGLrVQj-ggfa4xkZaGw}{E9Ysac5MQ36ZMiaxk302Pw}{127.0.0.1}{127.0.0.1:19201}]
2024-08-30 09:01:03 INFO [org.elasticsearch.http.netty4.Netty4HttpServerTransport.doStart(Netty4HttpServerTransport.java:321)] - publish_address {127.0.0.1:19200}, bound_addresses {[::1]:19200}, {127.0.0.1:19200}
2024-08-30 09:01:03 INFO [org.elasticsearch.node.Node.start(Node.java:759)] - started
2024-08-30 09:01:03 INFO [org.elasticsearch.gateway.GatewayService$GatewayRecoveryListener$1.clusterStateProcessed(GatewayService.java:301)] - recovered [0] indices into cluster_state
[main] INFO org.lobid.resources.CulturegraphXmlFilterHbzToJsonTest - Start extraction, transformation and creation of json bulk ... 
[main] INFO org.lobid.resources.CulturegraphXmlFilterHbzToJsonTest - Done extraction, transformation and creation of json bulk
2024-08-30 09:01:04 INFO [org.elasticsearch.cluster.metadata.MetaDataCreateIndexService$1.execute(MetaDataCreateIndexService.java:454)] - [cg] creating index, cause [auto(bulk api)], templates [], shards [5]/[1], mappings []
2024-08-30 09:01:05 INFO [org.elasticsearch.cluster.metadata.MetaDataDeleteIndexService.deleteIndices(MetaDataDeleteIndexService.java:100)] - [cg/zFwSqcjPTHuNzCeRD_3pbQ] deleting index
2024-08-30 09:01:05 INFO [org.elasticsearch.node.Node.stop(Node.java:769)] - stopping ...
2024-08-30 09:01:05 INFO [org.elasticsearch.node.Node.stop(Node.java:798)] - stopped
2024-08-30 09:01:05 INFO [org.elasticsearch.node.Node.close(Node.java:816)] - closing ...
2024-08-30 09:01:05 INFO [org.elasticsearch.node.Node.close(Node.java:888)] - closed
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 41.718 sec - in UnitTests

Results :

Tests run: 4, Failures: 0, Errors: 0, Skipped: 0

[INFO] 
[INFO] --- maven-jar-plugin:2.4:jar (default-jar) @ lobid-resources ---
[INFO] Building jar: /home/tobias/git/lobid-resources/target/lobid-resources-1.0.1-SNAPSHOT.jar
[INFO] 
[INFO] --- maven-install-plugin:2.4:install (default-install) @ lobid-resources ---
[INFO] Installing /home/tobias/git/lobid-resources/target/lobid-resources-1.0.1-SNAPSHOT.jar to /home/tobias/.m2/repository/org/lobid/lobid-resources/1.0.1-SNAPSHOT/lobid-resources-1.0.1-SNAPSHOT.jar
[INFO] Installing /home/tobias/git/lobid-resources/pom.xml to /home/tobias/.m2/repository/org/lobid/lobid-resources/1.0.1-SNAPSHOT/lobid-resources-1.0.1-SNAPSHOT.pom
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  53.720 s
[INFO] Finished at: 2024-08-30T09:01:08+02:00
[INFO] ------------------------------------------------------------------------

@TobiasNx TobiasNx assigned dr0i and unassigned TobiasNx Aug 30, 2024
@dr0i
Copy link
Member Author

dr0i commented Aug 30, 2024

Does it not? :

[main] INFO org.metafacture.monitoring.StreamBatchLogger - records processed: 152

If you are unsure, just git reset to some moths ago and run that to compare.

@dr0i dr0i assigned TobiasNx and unassigned dr0i Aug 30, 2024
@TobiasNx
Copy link
Contributor

@dr0i you are right:

 (default-test) @ lobid-resources ---

-------------------------------------------------------
 T E S T S
-------------------------------------------------------
Running UnitTests
[main] INFO de.hbz.lobid.helper.EtikettMaker - use labels directory: /home/tobias/git/lobid-resources/target/classes/labels
[main] INFO de.hbz.lobid.helper.EtikettMaker - Create labels....
[main] INFO de.hbz.lobid.helper.EtikettMaker - ...succeed!
[main] INFO de.hbz.lobid.helper.EtikettMaker - Writing context file ...
[main] INFO de.hbz.lobid.helper.EtikettMaker - ... done writing context file to web/conf/context.jsonld.
[main] INFO org.lobid.resources.AlmaMarc21XmlToLobidJsonMetafixTest - Starting transforming File
[main] INFO de.hbz.lobid.helper.EtikettMaker - use labels directory: /home/tobias/git/lobid-resources/target/classes/labels
[main] INFO de.hbz.lobid.helper.EtikettMaker - Create labels....
[main] INFO de.hbz.lobid.helper.EtikettMaker - ...succeed!
[main] INFO de.hbz.lobid.helper.EtikettMaker - Writing context file ...
[main] INFO de.hbz.lobid.helper.EtikettMaker - ... done writing context file to web/conf/context.jsonld.
[main] INFO org.metafacture.monitoring.StreamBatchLogger - records processed: 10
[main] INFO org.metafacture.monitoring.StreamBatchLogger - records processed: 20
[main] INFO org.metafacture.monitoring.StreamBatchLogger - records processed: 30
[main] INFO org.metafacture.monitoring.StreamBatchLogger - records processed: 40
[main] INFO org.metafacture.monitoring.StreamBatchLogger - records processed: 50
[main] INFO org.metafacture.monitoring.StreamBatchLogger - records processed: 60
[main] INFO org.metafacture.monitoring.StreamBatchLogger - records processed: 70
[main] INFO org.metafacture.monitoring.StreamBatchLogger - records processed: 80
[main] INFO org.metafacture.monitoring.StreamBatchLogger - records processed: 90
[main] INFO org.metafacture.monitoring.StreamBatchLogger - records processed: 100
[main] INFO org.metafacture.monitoring.StreamBatchLogger - records processed: 110
[main] INFO org.metafacture.monitoring.StreamBatchLogger - records processed: 120
[main] INFO org.metafacture.monitoring.StreamBatchLogger - records processed: 130
[main] INFO org.metafacture.monitoring.StreamBatchLogger - records processed: 140
[main] INFO org.metafacture.monitoring.StreamBatchLogger - records processed: 143
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 11.895 sec - in UnitTests

Results :

Tests run: 2, Failures: 0, Errors: 0, Skipped: 0

[INFO] 
[INFO] --- maven-jar-plugin:2.4:jar (default-jar) @ lobid-resources ---
[INFO] Building jar: /home/tobias/git/lobid-resources/target/lobid-resources-0.6.0-SNAPSHOT.jar
[INFO] 
[INFO] --- maven-install-plugin:2.4:install (default-install) @ lobid-resources ---
[INFO] Installing /home/tobias/git/lobid-resources/target/lobid-resources-0.6.0-SNAPSHOT.jar to /home/tobias/.m2/repository/org/lobid/lobid-resources/0.6.0-SNAPSHOT/lobid-resources-0.6.0-SNAPSHOT.jar
[INFO] Installing /home/tobias/git/lobid-resources/pom.xml to /home/tobias/.m2/repository/org/lobid/lobid-resources/0.6.0-SNAPSHOT/lobid-resources-0.6.0-SNAPSHOT.pom
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  17.390 s
[INFO] Finished at: 2024-08-30T14:00:49+02:00
[INFO] ------------------------------------------------------------------------
tobias@buelte-ThinkPad-X1-Carbon-Gen-8:~/git/lobid-resources$ 

This is the log of a commit from last years november. The log message is a little bit shorter.

+1 in my opinion.

@TobiasNx TobiasNx assigned dr0i and unassigned TobiasNx Aug 30, 2024
@dr0i dr0i merged commit c7065a3 into master Aug 30, 2024
1 check passed
@dr0i dr0i deleted the 2042-fixLogging branch August 30, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mvn clean install -DskipTests=false -DgenerateTestData=true does not log/count the ALMA Tests anymore?
2 participants