Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lookup gnd2 formangabe #2092

Merged
merged 5 commits into from
Nov 7, 2024
Merged

lookup gnd2 formangabe #2092

merged 5 commits into from
Nov 7, 2024

Conversation

maipet
Copy link
Contributor

@maipet maipet commented Nov 5, 2024

Related to #2082. Replaces #2090

  1. Fixes wrong mapping for formangabe label to natureOfContent.id.
  2. Adds mapping for labels if only id is given.

Copy link
Contributor

@TobiasNx TobiasNx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 nice :)

@TobiasNx TobiasNx assigned maipet and unassigned TobiasNx Nov 5, 2024
@TobiasNx
Copy link
Contributor

TobiasNx commented Nov 6, 2024

I assigne @dr0i for final review and merging.

@TobiasNx TobiasNx assigned dr0i and unassigned maipet Nov 6, 2024
@TobiasNx TobiasNx requested a review from dr0i November 6, 2024 07:33
@maipet maipet mentioned this pull request Nov 6, 2024
@dr0i dr0i merged commit c32cadd into master Nov 7, 2024
1 check passed
@dr0i dr0i deleted the 2082-LookupGnd2Formangabe branch November 7, 2024 08:59
@dr0i
Copy link
Member

dr0i commented Nov 7, 2024

Deployed next Monday. Closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants