Quote all classpath entries to handle spaces #1387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hcoles
force-pushed
the
bug/spaces_in_paths
branch
4 times, most recently
from
4b9a083 to
0aad768
Compare
hcoles
force-pushed
the
bug/spaces_in_paths
branch
from
0aad768 to
67ef7b2
Compare
szpak
reviewed
Feb 17, 2025
| @@ -11,6 +11,7 @@ | |||
| import java.net.URL; | |||
| import java.util.Arrays; | |||
| import java.util.Collections; | |||
| import java.util.Optional; | |||
szpak
reviewed
Feb 17, 2025
| @@ -108,8 +108,8 @@ private List<String> createLaunchArgs(JavaAgent agentJarLocator, List<String> ar | |||
| List<String> cmd = new ArrayList<>(); | |||
|
|
|||
| cmd.add("-classpath"); | |||
| cmd.add(classPath); | |||
|
|
|||
| cmd.add(classPath.replace(" ", "\" \"")); | |||
There was a problem hiding this comment.
I wonder, if it can affect the Gradle plugin, in the way how it already passes the classpath entries 🤔
There was a problem hiding this comment.
It has just occurred to me that this change would cause a problem if gradle were already quoting the the spaces. Otherwise, this should have no impact.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.