Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only first match option. #28

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

grigory-leonenko
Copy link

No description provided.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling fe63130 on StartupMakers:master into * on helior:master*.

@helior
Copy link
Owner

helior commented May 20, 2016

Hey @grigory-leonenko, thanks for writing this feature! There was a previous discussion around this in #23 and I brought up the notion of highlighting the n-th index of matches, instead of just the first. That would definitely handle the first-match use-case, as well as the last-match, and anywhere else in-between using the same property (this.props.indexMatchOnly?)

It would be amazing if you could incorporate that abstraction in your code-change as well. Let me know! Thanks!

@DenisIzmaylov
Copy link

DenisIzmaylov commented May 21, 2016

+1! Could you merge that?

The first match is the most reasonable use case, have a look at:
https://www.google.com/
http://www.bing.com/
https://duckduckgo.com/

image

@DenisIzmaylov
Copy link

DenisIzmaylov commented May 23, 2016

@helior could you please merge it?
Also I think we can bump the version to 0.4.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants