Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

H4HIP: CRD updating #379

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

H4HIP: CRD updating #379

wants to merge 1 commit into from

Conversation

gjenkins8
Copy link
Member

No description provided.

@gjenkins8 gjenkins8 force-pushed the hip4_crd_appending branch 2 times, most recently from eb8ecef to 2b5d9d7 Compare December 21, 2024 05:00
@gjenkins8
Initial draft
343cb9f 
Signed-off-by: George Jenkins <[email protected]>
@kfox1111
Copy link

Its pretty common these days for crds to be in templates so they can be upgraded too. We should probably keep this behavior and align it with the /crds directory too.

Maybe:

  • Render templates part 1. Render out any crds found, ignoring other templates. Treat the rendered crds as if in /crds, apply those. Render templates part 2. Render everything but the crds as normal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gjenkins8 @kfox1111