Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add custom kubeconfig option as action input #119

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

jbattiato
Copy link
Contributor

@jbattiato jbattiato commented Sep 27, 2024

Adding the custom kubeconfig option to pass it as an action input allows anyone to specify a certain KUBECONFIG environment variable to be used along the entire workflow job.

E.G.: I had to create a kind cluster to run some commands. This command requires the $KUBECONFIG to contain the actual kubernetes config path. With this patch I'm allowed to export the variable required to the next steps with certainty that I'm using the right kubernetes config.

Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

thanks

@cpanato cpanato merged commit 5d66646 into helm:main Sep 30, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants