Skip to content

Commit

Permalink
PR feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
mara-schulke committed Dec 26, 2023
1 parent ec08660 commit 06b830a
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
2 changes: 1 addition & 1 deletion docs/src/reference/editions.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ automatically inlined once a package is created using buffrs. This ensures that
you dont need to care about them as a user but get the benefits.

> Note: If you release a package with an edition that is incompatible with
> another one (e.g. `0.7` is incompatible with `0.8`) you will need to
> another one (e.g. if `0.7` is incompatible with `0.8`) you will need to
> re-release the package for the new edition (by bumping the version, or
> overriding the existing package) to regain compatibility.
Expand Down
7 changes: 4 additions & 3 deletions src/manifest.rs
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,9 @@ pub enum Edition {
Unknown,
}

impl Default for Edition {
fn default() -> Self {
impl Edition {
/// The current / latest edition of buffrs
pub fn latest() -> Self {
Self::Canary
}
}
Expand Down Expand Up @@ -289,7 +290,7 @@ impl Manifest {
/// Create a new manifest of the current edition
pub fn new(package: Option<PackageManifest>, dependencies: Vec<Dependency>) -> Self {
Self {
edition: Edition::default(),
edition: Edition::latest(),
package,
dependencies,
}
Expand Down

0 comments on commit 06b830a

Please sign in to comment.