lenses/fstab.aug: Allow individual mount options to be empty #849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can be a list, but there's no evidence in the manual that vfstype=value is permitted, it's just a simple list of strings. Signed-off-by: Richard W.M. Jones <[email protected]>
Mount allows mount-option fields to be empty (I think it ignores them), but augeas gave an error. Allow this to be parsed. This does not preserve the empty option on write, but that should not change the meaning of the entry. Example: /dev/mapper/vg00-vartmp /var/tmp xfs rw,,nodev,nosuid,noexec,relatime 0 0 Fixes: https://issues.redhat.com/browse/RHEL-77279 Fixes: hercules-team#832 Signed-off-by: Richard W.M. Jones <[email protected]>
rwmjones
force-pushed
the
fix-fstab-empty-mntopts
branch
from
d6cd9b0 to
fd361c7
Compare
|
I don't like the full solution here. I think commit 5246ef0 was a hack, not a good fix for that problem. This adds something like another hack on top of that commit. I would prefer a solution where we allow option fields in the list to be empty, which would be a generalisation of both this PR & commit 5246ef0. However I could not work out how to actually express that as an Augeas lens, just getting lots of ambiguous parsing problems that I was unable to fix. |
rwmjones
changed the title
|
I'll have a look at this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mount allows mount-option fields to be empty (I think it ignores them), but augeas gave an error. Allow this to be parsed, preserving the empty option on write.
Example:
/dev/mapper/vg00-vartmp /var/tmp xfs rw,,nodev,nosuid,noexec,relatime 0 0Fixes: https://issues.redhat.com/browse/RHEL-77279
Fixes: #832
Signed-off-by: Richard W.M. Jones [email protected]