Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial groundwork for playing tones #164

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

a-sommer
Copy link

  • Added tonePlayer, concrete class for playing tones (in progress)
  • Modified PlatformPlayer if/else to route x-tone-seq correctly
  • Added initial implementations to Nokia Sound (in progress)

- Added tonePlayer, concrete class for playing tones (in progress)
- Modified PlatformPlayer if/else to route x-tone-seq correctly
- Added initial implementations to Nokia Sound (in progress)
@recompileorg
Copy link
Collaborator

Not a bad start. If you need any help with the Nokia formats, Just let me know. I wrote a little program to convert the music from Munkiki's Castles to MIDI for someone a few months back. Not that I recommend converting it to MIDI, but I can help with the formats.

I'd recommend not catching those exceptions, but declaring them thrown. We've found that some games use exceptions for ordinary control flow.

If we're going to support more formats (someone is or was working on adpcm support) we might want to replace that if/else chain with a more readable switch, something like switch(type.toLowerCase()) That will get rid of all the redundant "no player for" bits.

@a-sommer
Copy link
Author

Thanks! I appreciate it. I'll make those changes you recommend, and I'll reach out if I need help with the Nokia formats.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants