Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding usage info for pre-commit #724

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

behrisch
Copy link

No description provided.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (af7399d) 97.83% compared to head (468326f) 97.83%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #724   +/-   ##
=======================================
  Coverage   97.83%   97.83%           
=======================================
  Files           1        1           
  Lines        2402     2402           
=======================================
  Hits         2350     2350           
  Misses         52       52           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -401,6 +401,7 @@ To add autopep8 as a plugin, add this repo definition to your configuration:

.. _`pre-commit`: https://pre-commit.com

If you don't use a configuration file for autpep8, you'll want to include either ``args: [--in-place]`` or ``args: [--diff]``.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to rephrase this since the use of --in-place or --diff options should be recommended for pre-commit usage regardless of whether a configuration file is used or not. Here's my suggested text:

Suggested change
If you don't use a configuration file for autpep8, you'll want to include either ``args: [--in-place]`` or ``args: [--diff]``.
When using autopep8 with pre-commit, it is recommended to include either ``args: [--in-place]`` or ``args: [--diff]``.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants