HV-1831: Optimize cascading validation for large lists

validator/src/test/java/org/hibernate/validator/bugs/FirstChildBean.java

@@ -0,0 +1,35 @@
+package org.hibernate.validator.bugs;
+
+import javax.validation.Valid;
+import javax.validation.constraints.NotBlank;
+import java.util.List;
+import java.util.Objects;
+
+public class FirstChildBean {
+    @NotBlank
+    private String name;
+
+    // 3 to 4 further fields with simple validators
+
+    @Valid
+    private List<SecondChildBean> secondChildren;
+
+    public FirstChildBean(String name, List<SecondChildBean> secondChildren) {
+        this.name = name;
+        this.secondChildren = secondChildren;
+    }
+
+    @Override
+    public boolean equals(Object o) {
+        if (this == o) return true;
+        if (o == null || getClass() != o.getClass()) return false;
+        FirstChildBean that = (FirstChildBean) o;
+        return Objects.equals(name, that.name) &&
+                Objects.equals(secondChildren, that.secondChildren);
+    }
+
+    @Override
+    public int hashCode() {
+        return Objects.hash(name, secondChildren);
+    }
+}

validator/src/test/java/org/hibernate/validator/bugs/ParentAnnotatedBean.java

@@ -0,0 +1,36 @@
+package org.hibernate.validator.bugs;
+
+import javax.validation.Valid;
+import javax.validation.constraints.NotBlank;
+import javax.validation.constraints.Size;
+import java.util.List;
+
+public class ParentAnnotatedBean {
+
+	@NotBlank
+	@Size
+	private String name;
+
+	@Valid
+	private List<FirstChildBean> firstChildren;
+
+	protected ParentAnnotatedBean() {}
+
+	public ParentAnnotatedBean(String name, List<FirstChildBean> firstChildren) {
+		this.name = name;
+		this.firstChildren = firstChildren;
+	}
+
+	public List<FirstChildBean> getFirstChildren() { return firstChildren; }
+
+	public void setFirstChildren(List<FirstChildBean> firstChildren) { this.firstChildren = firstChildren; }
+
+	public String getName() {
+		return name;
+	}
+
+	public void setName(String name) {
+		this.name = name;
+	}
+
+}

validator/src/test/java/org/hibernate/validator/bugs/SecondChildBean.java

@@ -0,0 +1,48 @@
+package org.hibernate.validator.bugs;
+
+import javax.validation.constraints.NotBlank;
+import java.util.Objects;
+
+public class SecondChildBean {
+
+    @NotBlank
+    private String foo;
+
+    @NotBlank
+    private String bar;
+
+    public SecondChildBean(String foo, String bar) {
+        this.foo = foo;
+        this.bar = bar;
+    }
+
+    public String getFoo() {
+        return foo;
+    }
+
+    public void setFoo(String foo) {
+        this.foo = foo;
+    }
+
+    public String getBar() {
+        return bar;
+    }
+
+    public void setBar(String bar) {
+        this.bar = bar;
+    }
+
+    @Override
+    public boolean equals(Object o) {
+        if (this == o) return true;
+        if (o == null || getClass() != o.getClass()) return false;
+        SecondChildBean that = (SecondChildBean) o;
+        return Objects.equals(foo, that.foo) &&
+                Objects.equals(bar, that.bar);
+    }
+
+    @Override
+    public int hashCode() {
+        return Objects.hash(foo, bar);
+    }
+}

validator/src/test/java/org/hibernate/validator/bugs/YourTestCase.java

@@ -2,6 +2,8 @@
 
 import static org.junit.Assert.assertEquals;
 
+import java.util.ArrayList;
+import java.util.List;
 import java.util.Set;
 
 import javax.validation.ConstraintViolation;
@@ -24,15 +26,34 @@ public static void setUp() {
 	}
 
 	@Test
-	@TestForIssue(jiraKey = "HV-NNNNN") // Please fill in the JIRA key of your issue
+	@TestForIssue(jiraKey = "HV-1831") // Please fill in the JIRA key of your issue
 	public void testYourBug() {
-		YourAnnotatedBean yourEntity1 = new YourAnnotatedBean( null, "example" );
+		List<FirstChildBean> firstChildren = createFirstChildren();
 
-		Set<ConstraintViolation<YourAnnotatedBean>> constraintViolations = validator.validate( yourEntity1 );
-		assertEquals( 1, constraintViolations.size() );
-		assertEquals(
-				"must not be null",
-				constraintViolations.iterator().next().getMessage() );
+		ParentAnnotatedBean yourEntity1 = new ParentAnnotatedBean( "parent-bean", firstChildren );
+
+		Set<ConstraintViolation<ParentAnnotatedBean>> constraintViolations = validator.validate( yourEntity1 );
+		assertEquals( 0, constraintViolations.size() );
+	}
+
+	private List<FirstChildBean> createFirstChildren() {
+		List<FirstChildBean> firstChildren = new ArrayList<>();
+
+		for(int i = 0; i < 50; i++) {
+			firstChildren.add(new FirstChildBean("foo" + i, createSecondChildren()));
+		}
+
+		return firstChildren;
+	}
+
+	private List<SecondChildBean> createSecondChildren() {
+		List<SecondChildBean> secondChildren = new ArrayList<>();
+
+		for(int i = 0; i < 10; i++) {
+			secondChildren.add(new SecondChildBean("foo" + i, "bar" + i));
+		}
+
+		return secondChildren;
 	}
 
 }