Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump arquillian and WildFly launcher versions #1509

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

marko-bekhta
Copy link
Member

to address issues with the security manager on JDK 24


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on licensing, please check here.


@hibernate-github-bot
Copy link

hibernate-github-bot bot commented Dec 9, 2024

Thanks for your pull request!

This pull request does not follow the contribution rules. Could you have a look?

❌ All commit messages should start with a JIRA issue key matching pattern HV-\d+
    ↳ Offending commits: [0031768]

› This message was automatically generated.

@marko-bekhta
Copy link
Member Author

Hi @jamezp
I saw that you've been working on various Arquillian+WildFly patches to make things work with JDK 24 and the Security Manager... But I lost track of it 🙈 😕 hence I thought I'd ping you to see if there's a combination of dependencies that would work on JDK 24 🙈 😃

@jamezp
Copy link

jamezp commented Dec 9, 2024

Hi @jamezp I saw that you've been working on various Arquillian+WildFly patches to make things work with JDK 24 and the Security Manager... But I lost track of it 🙈 😕 hence I thought I'd ping you to see if there's a combination of dependencies that would work on JDK 24 🙈 😃

Hello @marko-bekhta, I've actually not done much with Arquillian itself. However, I do think it likely needs some work. I've got some ideas on how it could work though. I'm not 100% sure when I'll have a chance to look, but hopefully I can this week.

@marko-bekhta
Copy link
Member Author

Oh ok thanks!
I'll try to keep an eye on the updates then :)

@jamezp
Copy link

jamezp commented Dec 9, 2024

@marko-bekhta I just ran the WildFly Arquillian with Java 24 and it actually passes. The catch is it's a SNAPSHOT version and it requires WildFly 35.0.0.Beta1-SNAPSHOT :)

I can probably do a release of WildFly Aquillian this week. Just note, you'll have to either configure WildFly without jacc configured in Elytron or wait until WildFly 35 is released.

to address issues with security manager on JDK 24
@marko-bekhta marko-bekhta force-pushed the test/fix-jdk-24-builds branch from fdf4f83 to 0031768 Compare December 10, 2024 09:19
@marko-bekhta
Copy link
Member Author

I couldn't find any snapshots at https://repository.jboss.org/nexus/content/repositories/snapshots/org/wildfly/ so I've built them locally and can confirm that using WildFly preview 35.0.0.Beta1-SNAPSHOT and Arquillian 5.1.0.Beta8-SNAPSHOT works for the HV build 🎉

I've tried using a patched version of 34.0.1.Final preview, where

<policy name="jacc">
    <jacc-policy/>
</policy>

is removed from the wildfly-preview-34.0.1.Final/standalone/configuration/standalone.xml but the test was still failing because of the Security Manager..
I think we'll just wait for those new versions and then fix the JDK 24 build.

Thanks for looking into this James!

Copy link

sonarqubecloud bot commented Jan 3, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants