Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ARG HTTP_PROXY in Dockerfile to support HTTP proxy during image building #6462

Merged
merged 2 commits into from
Jan 2, 2025

Conversation

shibingli
Copy link
Contributor

@shibingli shibingli commented Dec 27, 2024

Add ARG HTTP_PROXY in Dockerfile to support HTTP proxy during image building.

This commit introduces an ARG parameter named HTTP_PROXY in the Dockerfile. This addition allows for the configuration of an HTTP proxy, facilitating image building in environments with network restrictions.

What does this PR do?

Fixes # (issue)

Before submitting

…uilding.This commit introduces an ARG parameter named HTTP_PROXY in the Dockerfile. This addition allows for the configuration of an HTTP proxy, facilitating image building in environments with network restrictions.
@hiyouga hiyouga self-requested a review January 2, 2025 11:32
Copy link
Owner

@hiyouga hiyouga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hiyouga hiyouga merged commit 8741e5b into hiyouga:main Jan 2, 2025
@hiyouga hiyouga added the solved This problem has been already solved label Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
solved This problem has been already solved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants