Skip to content

Commit

Permalink
rename chapter_24_CI to chapter_25_CI.
Browse files Browse the repository at this point in the history
  • Loading branch information
hjwp committed Oct 13, 2024
1 parent 55fe04c commit 5ce5ffa
Show file tree
Hide file tree
Showing 15 changed files with 19 additions and 19 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ jobs:
test_chapter_22_fixtures_and_wait_decorator,
test_chapter_23_debugging_prod,
test_chapter_24_outside_in,
test_chapter_24_CI,
test_chapter_25_CI,
test_chapter_25_page_pattern,
]

Expand Down
4 changes: 2 additions & 2 deletions .gitmodules
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,8 @@
[submodule "source/chapter_24_outside_in/superlists"]
path = source/chapter_24_outside_in/superlists
url = [email protected]:hjwp/book-example.git
[submodule "source/chapter_24_CI/superlists"]
path = source/chapter_24_CI/superlists
[submodule "source/chapter_25_CI/superlists"]
path = source/chapter_25_CI/superlists
url = [email protected]:hjwp/book-example.git
[submodule "source/chapter_25_page_pattern/superlists"]
path = source/chapter_25_page_pattern/superlists
Expand Down
6 changes: 3 additions & 3 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -153,9 +153,9 @@ test_chapter_23_debugging_prod: chapter_23_debugging_prod.html $(TMPDIR) $(VENV)
.PHONY: test_chapter_24_outside_in
test_chapter_24_outside_in: chapter_24_outside_in.html $(TMPDIR) $(VENV)/bin
$(VENV)/bin/pytest -s --tb=short ./tests/test_chapter_24_outside_in.py
.PHONY: test_chapter_24_CI
test_chapter_24_CI: chapter_24_CI.html $(TMPDIR) $(VENV)/bin
$(VENV)/bin/pytest -s --tb=short ./tests/test_chapter_24_CI.py
.PHONY: test_chapter_25_CI
test_chapter_25_CI: chapter_25_CI.html $(TMPDIR) $(VENV)/bin
$(VENV)/bin/pytest -s --tb=short ./tests/test_chapter_25_CI.py
.PHONY: test_chapter_25_page_pattern
test_chapter_25_page_pattern: chapter_25_page_pattern.html $(TMPDIR) $(VENV)/bin
$(VENV)/bin/pytest -s --tb=short ./tests/test_chapter_25_page_pattern.py
Expand Down
4 changes: 2 additions & 2 deletions appendix_IX_cheat_sheet.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ system testing early. Ensure your components work together: web server,
* Build a CI server as soon as possible, so that you don't have to rely
on self-discipline to see the tests run.
Relevant chapters: <<chapter_11_server_prep>>, <<chapter_24_CI>>
Relevant chapters: <<chapter_11_server_prep>>, <<chapter_25_CI>>


General Testing Best Practices
Expand Down Expand Up @@ -122,7 +122,7 @@ Selenium/Functional Testing Best Practices
* Look into BDD tools as another way of structuring your FTs.
Relevant chapters: <<chapter_23_debugging_prod>>, <<chapter_24_CI>>,
Relevant chapters: <<chapter_23_debugging_prod>>, <<chapter_25_CI>>,
<<chapter_25_page_pattern>>

Outside-In, Test Isolation Versus Integrated Tests, and Mocking
Expand Down
4 changes: 2 additions & 2 deletions appendix_I_PythonAnywhere.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ Firefox can't start because there's no display for it to run on, because
PythonAnywhere is a server environment. The workaround is to use 'Xvfb', which
stands for X Virtual Framebuffer. It will start up a "virtual" display, which
Firefox can use even though the server doesn't have a real one (we use the same
tool in <<chapter_24_CI>> to run tests on a CI server).
tool in <<chapter_25_CI>> to run tests on a CI server).


The command `xvfb-run` will run the next command in Xvfb. Using that will give
Expand Down Expand Up @@ -184,7 +184,7 @@ Instead, you can inspect the live site, or you could "take my word for it"
regarding what you should see.

The best way of doing visual inspections of tests that run in a virtual display
is to use screenshots. Take a look at <<chapter_24_CI>> if you're
is to use screenshots. Take a look at <<chapter_25_CI>> if you're
curious--there's some example code in there.


Expand Down
2 changes: 1 addition & 1 deletion appendix_github_links.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ Full List of Links for Each Chapter
<<chapter_23_debugging_prod>>:: https://github.com/hjwp/book-example/tree/chapter_23_debugging_prod
<<chapter_24_outside_in>>:: https://github.com/hjwp/book-example/tree/chapter_24_outside_in
<<appendix_purist_unit_tests>>:: https://github.com/hjwp/book-example/tree/appendix_purist_unit_tests
<<chapter_24_CI>>:: https://github.com/hjwp/book-example/tree/chapter_24_CI
<<chapter_25_CI>>:: https://github.com/hjwp/book-example/tree/chapter_25_CI
<<chapter_25_page_pattern>>:: https://github.com/hjwp/book-example/tree/chapter_25_page_pattern
<<appendix_Django_Class-Based_Views>>:: https://github.com/hjwp/book-example/tree/appendix_Django_Class-Based_Views
<<appendix_bdd>>:: https://github.com/hjwp/book-example/tree/appendix_bdd
Expand Down
2 changes: 1 addition & 1 deletion atlas.json
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
"chapter_22_fixtures_and_wait_decorator.asciidoc",
"chapter_23_debugging_prod.asciidoc",
"chapter_24_outside_in.asciidoc",
"chapter_24_CI.asciidoc",
"chapter_25_CI.asciidoc",
"chapter_25_page_pattern.asciidoc",
"chapter_26_hot_lava.asciidoc",
"epilogue.asciidoc",
Expand Down
2 changes: 1 addition & 1 deletion book.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ include::chapter_21_mocking_2.asciidoc[]
include::chapter_22_fixtures_and_wait_decorator.asciidoc[]
include::chapter_23_debugging_prod.asciidoc[]
include::chapter_24_outside_in.asciidoc[]
include::chapter_24_CI.asciidoc[]
include::chapter_25_CI.asciidoc[]
include::chapter_25_page_pattern.asciidoc[]
include::chapter_26_hot_lava.asciidoc[]

Expand Down
2 changes: 1 addition & 1 deletion chapter_06_explicit_waits_1.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -536,7 +536,7 @@ NOTE: Did you get a bit bored waiting 5 seconds for the test to fail?
Making MAX_WAIT configurable so that it's fast in local dev,
but more conservative on Continuous Integration (CI) servers
can be a good idea.
See <<chapter_24_CI>> for an introduction to CI.
See <<chapter_25_CI>> for an introduction to CI.

Let's put that back the way it was and break something else:

Expand Down
2 changes: 1 addition & 1 deletion chapter_24_CI.asciidoc → chapter_25_CI.asciidoc
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
[[chapter_24_CI]]
[[chapter_25_CI]]
== Continuous Integration (CI)

.Warning, Chapter Update in Progress
Expand Down
2 changes: 1 addition & 1 deletion epilogue.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ Keep Your CI Builds Green

((("Continuous Integration (CI)", "tips")))Another
area that takes real hard work is continuous integration. You saw in
<<chapter_24_CI>> that strange and unpredictable bugs sometimes occur on CI.
<<chapter_25_CI>> that strange and unpredictable bugs sometimes occur on CI.
When you're looking at these and thinking "it works fine on my machine",
there's a strong temptation to just ignore them...but, if you're not careful,
you start to tolerate a failing test suite in CI, and pretty soon your CI build
Expand Down
2 changes: 1 addition & 1 deletion tests/chapters.py
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
"chapter_22_fixtures_and_wait_decorator",
"chapter_23_debugging_prod",
"chapter_24_outside_in",
"chapter_24_CI",
"chapter_25_CI",
"chapter_25_page_pattern",

"chapter_26_hot_lava",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@


class Chapter23Test(ChapterTest):
chapter_name = "chapter_24_CI"
chapter_name = "chapter_25_CI"
previous_chapter = "chapter_24_outside_in"

def test_listings_and_commands_and_output(self):
Expand Down
2 changes: 1 addition & 1 deletion tests/test_chapter_25_page_pattern.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

class Chapter22Test(ChapterTest):
chapter_name = "chapter_25_page_pattern"
previous_chapter = "chapter_24_CI"
previous_chapter = "chapter_25_CI"

def test_listings_and_commands_and_output(self):
self.parse_listings()
Expand Down

0 comments on commit 5ce5ffa

Please sign in to comment.