Skip to content

Commit

Permalink
Remove role=button for nav link - Issue hostolab#755
Browse files Browse the repository at this point in the history
  • Loading branch information
hmartinez69 committed Jun 2, 2021
1 parent 36ddc61 commit 957baaf
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion app/views/layouts/_navbar.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
<%= link_to "Professionnels de santé", landing_page_pro_path, class: "nav-link" %>
</li>
<li class="nav-item dropdown">
<a class="nav-link dropdown-toggle" data-toggle="dropdown" href="#dropdownHelpers" role="button" aria-haspopup="true" aria-expanded="false">Ils nous aident</a>

This comment has been minimized.

Copy link
@viki53

viki53 Jun 2, 2021

Attention ici il s'agit bien d'un bouton (action locale, pas de navigation), le role est bien à sa place

This comment has been minimized.

Copy link
@viki53

viki53 Jun 2, 2021

Il en manque par contre un pour le dropdown suivant ("Se connecter") qui a le même usage

<a class="nav-link dropdown-toggle" data-toggle="dropdown" href="#dropdownHelpers" aria-haspopup="true" aria-expanded="false">Ils nous aident</a>
<div class="dropdown-menu" aria-labelledby="dropdownHelpers">
<%= link_to "Donateurs", donateurs_path, class: class_names("dropdown-item", active: current_page?(donateurs_path)) %>
<%= link_to "Sponsors", sponsors_path, class: class_names("dropdown-item", active: current_page?(sponsors_path)) %>
Expand Down

0 comments on commit 957baaf

Please sign in to comment.