-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DFPL-C110a C110a Feature Branch #5498
Draft
qasimnawaz-moj
wants to merge
44
commits into
master
Choose a base branch
from
DFPL-C110a
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* DFPL-2295: c110a Design Changes to International Element * Add default return statement * Fix checkstyle * Fix robotics tests * Fix tests * Update test resources * Fix functional tests * Update C110A template * Fix old fields showing up in UI * Update C110a template * Add old fields to avoid deserialization issues * Revert changes to 00095 doc * Add CaseEventToComplexTypes for international element * Fix bug with mandatory fields not being enforced * Add international element notice * Update styling --------- Co-authored-by: jamesrferguson1 <[email protected]> Co-authored-by: prabhamuthu15 <[email protected]>
github-actions
bot
added
docmosis
Pull requests that update Docmosis templates
ccd configuration
Pull request that updates CCD definition configuration
labels
Jul 16, 2024
…Parenting Sections (#5492) * DFPL-2295: c110a Design Changes to International Element * Add default return statement * Fix checkstyle * Fix robotics tests * Fix tests * Update test resources * Fix functional tests * Update C110A template * Fix old fields showing up in UI * Update C110a template * Add old fields to avoid deserialization issues * Revert changes to 00095 doc * Add CaseEventToComplexTypes for international element * Fix bug with mandatory fields not being enforced * Add international element notice * Update styling * DFPL-2303: c110a Design Changes to Risk and Harm & Factors Affecting Parenting Sections * Fix typo * Deprecate existing fields * Make all fields in event mandatory * Update models * Update submission service * Update robotics service * Update Risk checker * Add tests * Remove whitespace * Fix checkstyle * Fix checkstyle * Fix tests * Update callback for testing * Modify docmosis template and generation logic * Re-add old fields * Update tests * Remove factorsParenting docmosis generation * Fix tests * Fix case details for tests * Fix list bug * Remove factors affecting parenting logic * Uodate renderer logic * Update task list rescources for tests * Fix tests * Remove import * Fix issue with C110a doc generation * Update test resources * Fix case submission generation logic * Fix tests * remove unused function * test update * checkstyle --------- Co-authored-by: jamesrferguson1 <[email protected]> Co-authored-by: prabhamuthu15 <[email protected]>
* AddSystemUserPermissionToHearingPreferenceField * courtserviceUiTest * RemoveLogMsg
Plan Result (aat)
Change Result (Click me) # azurerm_key_vault_secret.update-summary-tab-cron will be updated in-place
~ resource "azurerm_key_vault_secret" "update-summary-tab-cron" {
id = "https://fpl-aat.vault.azure.net/secrets/update-summary-tab-cron/610e9d1fb33f446c9b8ee86a6a49b90b"
name = "update-summary-tab-cron"
- not_before_date = "2023-11-22T08:32:40Z" -> null
tags = {}
# (7 unchanged attributes hidden)
}
# module.fpl-action-group.azurerm_resource_group_template_deployment.action-group will be updated in-place
~ resource "azurerm_resource_group_template_deployment" "action-group" {
id = "/subscriptions/1c4f0704-a29e-403d-b719-b90c34ef14c9/resourceGroups/fpl-case-service-aat/providers/Microsoft.Resources/deployments/fpl-support"
name = "fpl-support"
tags = {}
~ template_content = jsonencode(
~ {
~ outputs = {
~ actionGroupId = {
~ type = "String" -> "string"
# (1 unchanged attribute hidden)
}
}
~ parameters = {
~ actionGroupName = {
~ type = "String" -> "string"
}
~ emailReceiverAddress = {
~ type = "String" -> "string"
# (1 unchanged attribute hidden)
}
~ emailReceiverName = {
~ type = "String" -> "string"
# (1 unchanged attribute hidden)
}
~ location = {
~ type = "String" -> "string"
# (1 unchanged attribute hidden)
}
~ shortName = {
~ type = "String" -> "string"
}
}
# (3 unchanged attributes hidden)
}
)
# (6 unchanged attributes hidden)
}
Plan: 0 to add, 2 to change, 0 to destroy. |
Plan Result (prod)
Change Result (Click me) # module.fpl-action-group.azurerm_resource_group_template_deployment.action-group will be updated in-place
~ resource "azurerm_resource_group_template_deployment" "action-group" {
id = "/subscriptions/8999dec3-0104-4a27-94ee-6588559729d1/resourceGroups/fpl-case-service-prod/providers/Microsoft.Resources/deployments/fpl-support"
name = "fpl-support"
tags = {}
~ template_content = jsonencode(
~ {
~ outputs = {
~ actionGroupId = {
~ type = "String" -> "string"
# (1 unchanged attribute hidden)
}
}
~ parameters = {
~ actionGroupName = {
~ type = "String" -> "string"
}
~ emailReceiverAddress = {
~ type = "String" -> "string"
# (1 unchanged attribute hidden)
}
~ emailReceiverName = {
~ type = "String" -> "string"
# (1 unchanged attribute hidden)
}
~ location = {
~ type = "String" -> "string"
# (1 unchanged attribute hidden)
}
~ shortName = {
~ type = "String" -> "string"
}
}
# (3 unchanged attributes hidden)
}
)
# (6 unchanged attributes hidden)
}
# module.fpl-exceptions-alert.azurerm_resource_group_template_deployment.custom_alert[0] will be updated in-place
~ resource "azurerm_resource_group_template_deployment" "custom_alert" {
id = "/subscriptions/8999dec3-0104-4a27-94ee-6588559729d1/resourceGroups/fpl-case-service-prod/providers/Microsoft.Resources/deployments/fpl-exceptions"
name = "fpl-exceptions"
tags = {}
~ template_content = jsonencode(
~ {
~ parameters = {
~ actionGroupName = {
~ type = "String" -> "string"
}
~ actionGroupRg = {
~ type = "String" -> "string"
}
~ alertDesc = {
~ type = "String" -> "string"
}
~ alertName = {
~ type = "String" -> "string"
}
~ appInsightsName = {
~ type = "String" -> "string"
}
~ appInsightsQuery = {
~ type = "String" -> "string"
}
~ commonTags = {
~ type = "String" -> "string"
}
~ customEmailSubject = {
~ type = "String" -> "string"
}
~ frequencyInMinutes = {
~ type = "String" -> "string"
# (1 unchanged attribute hidden)
}
~ location = {
~ type = "String" -> "string"
}
~ severityLevel = {
~ type = "String" -> "string"
# (1 unchanged attribute hidden)
}
~ timeWindowInMinutes = {
~ type = "String" -> "string"
# (1 unchanged attribute hidden)
}
~ triggerThreshold = {
~ type = "String" -> "string"
}
~ triggerThresholdOperator = {
~ type = "String" -> "string"
# (2 unchanged attributes hidden)
}
}
# (4 unchanged attributes hidden)
}
)
# (6 unchanged attributes hidden)
}
# module.fpl-health-failure-alert.azurerm_resource_group_template_deployment.custom_alert[0] will be updated in-place
~ resource "azurerm_resource_group_template_deployment" "custom_alert" {
id = "/subscriptions/8999dec3-0104-4a27-94ee-6588559729d1/resourceGroups/fpl-case-service-prod/providers/Microsoft.Resources/deployments/fpl-health-failure"
name = "fpl-health-failure"
tags = {}
~ template_content = jsonencode(
~ {
~ parameters = {
~ actionGroupName = {
~ type = "String" -> "string"
}
~ actionGroupRg = {
~ type = "String" -> "string"
}
~ alertDesc = {
~ type = "String" -> "string"
}
~ alertName = {
~ type = "String" -> "string"
}
~ appInsightsName = {
~ type = "String" -> "string"
}
~ appInsightsQuery = {
~ type = "String" -> "string"
}
~ commonTags = {
~ type = "String" -> "string"
}
~ customEmailSubject = {
~ type = "String" -> "string"
}
~ frequencyInMinutes = {
~ type = "String" -> "string"
# (1 unchanged attribute hidden)
}
~ location = {
~ type = "String" -> "string"
}
~ severityLevel = {
~ type = "String" -> "string"
# (1 unchanged attribute hidden)
}
~ timeWindowInMinutes = {
~ type = "String" -> "string"
# (1 unchanged attribute hidden)
}
~ triggerThreshold = {
~ type = "String" -> "string"
}
~ triggerThresholdOperator = {
~ type = "String" -> "string"
# (2 unchanged attributes hidden)
}
}
# (4 unchanged attributes hidden)
}
)
# (6 unchanged attributes hidden)
}
# module.fpl-performance-alert.azurerm_resource_group_template_deployment.custom_alert[0] will be updated in-place
~ resource "azurerm_resource_group_template_deployment" "custom_alert" {
id = "/subscriptions/8999dec3-0104-4a27-94ee-6588559729d1/resourceGroups/fpl-case-service-prod/providers/Microsoft.Resources/deployments/fpl-performance"
name = "fpl-performance"
tags = {}
~ template_content = jsonencode(
~ {
~ parameters = {
~ actionGroupName = {
~ type = "String" -> "string"
}
~ actionGroupRg = {
~ type = "String" -> "string"
}
~ alertDesc = {
~ type = "String" -> "string"
}
~ alertName = {
~ type = "String" -> "string"
}
~ appInsightsName = {
~ type = "String" -> "string"
}
~ appInsightsQuery = {
~ type = "String" -> "string"
}
~ commonTags = {
~ type = "String" -> "string"
}
~ customEmailSubject = {
~ type = "String" -> "string"
}
~ frequencyInMinutes = {
~ type = "String" -> "string"
# (1 unchanged attribute hidden)
}
~ location = {
~ type = "String" -> "string"
}
~ severityLevel = {
~ type = "String" -> "string"
# (1 unchanged attribute hidden)
}
~ timeWindowInMinutes = {
~ type = "String" -> "string"
# (1 unchanged attribute hidden)
}
~ triggerThreshold = {
~ type = "String" -> "string"
}
~ triggerThresholdOperator = {
~ type = "String" -> "string"
# (2 unchanged attributes hidden)
}
}
# (4 unchanged attributes hidden)
}
)
# (6 unchanged attributes hidden)
}
# module.fpl-summary-tab-job-alert.azurerm_resource_group_template_deployment.custom_alert[0] will be updated in-place
~ resource "azurerm_resource_group_template_deployment" "custom_alert" {
id = "/subscriptions/8999dec3-0104-4a27-94ee-6588559729d1/resourceGroups/fpl-case-service-prod/providers/Microsoft.Resources/deployments/fpl-summary-tab-job-failure"
name = "fpl-summary-tab-job-failure"
tags = {}
~ template_content = jsonencode(
~ {
~ parameters = {
~ actionGroupName = {
~ type = "String" -> "string"
}
~ actionGroupRg = {
~ type = "String" -> "string"
}
~ alertDesc = {
~ type = "String" -> "string"
}
~ alertName = {
~ type = "String" -> "string"
}
~ appInsightsName = {
~ type = "String" -> "string"
}
~ appInsightsQuery = {
~ type = "String" -> "string"
}
~ commonTags = {
~ type = "String" -> "string"
}
~ customEmailSubject = {
~ type = "String" -> "string"
}
~ frequencyInMinutes = {
~ type = "String" -> "string"
# (1 unchanged attribute hidden)
}
~ location = {
~ type = "String" -> "string"
}
~ severityLevel = {
~ type = "String" -> "string"
# (1 unchanged attribute hidden)
}
~ timeWindowInMinutes = {
~ type = "String" -> "string"
# (1 unchanged attribute hidden)
}
~ triggerThreshold = {
~ type = "String" -> "string"
}
~ triggerThresholdOperator = {
~ type = "String" -> "string"
# (2 unchanged attributes hidden)
}
}
# (4 unchanged attributes hidden)
}
)
# (6 unchanged attributes hidden)
}
# module.fpl-upcoming-hearings-job-alert.azurerm_resource_group_template_deployment.custom_alert[0] will be updated in-place
~ resource "azurerm_resource_group_template_deployment" "custom_alert" {
id = "/subscriptions/8999dec3-0104-4a27-94ee-6588559729d1/resourceGroups/fpl-case-service-prod/providers/Microsoft.Resources/deployments/fpl-upcoming-hearings-job-failure"
name = "fpl-upcoming-hearings-job-failure"
tags = {}
~ template_content = jsonencode(
~ {
~ parameters = {
~ actionGroupName = {
~ type = "String" -> "string"
}
~ actionGroupRg = {
~ type = "String" -> "string"
}
~ alertDesc = {
~ type = "String" -> "string"
}
~ alertName = {
~ type = "String" -> "string"
}
~ appInsightsName = {
~ type = "String" -> "string"
}
~ appInsightsQuery = {
~ type = "String" -> "string"
}
~ commonTags = {
~ type = "String" -> "string"
}
~ customEmailSubject = {
~ type = "String" -> "string"
}
~ frequencyInMinutes = {
~ type = "String" -> "string"
# (1 unchanged attribute hidden)
}
~ location = {
~ type = "String" -> "string"
}
~ severityLevel = {
~ type = "String" -> "string"
# (1 unchanged attribute hidden)
}
~ timeWindowInMinutes = {
~ type = "String" -> "string"
# (1 unchanged attribute hidden)
}
~ triggerThreshold = {
~ type = "String" -> "string"
}
~ triggerThresholdOperator = {
~ type = "String" -> "string"
# (2 unchanged attributes hidden)
}
}
# (4 unchanged attributes hidden)
}
)
# (6 unchanged attributes hidden)
}
Plan: 0 to add, 6 to change, 0 to destroy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
aat/add-or-update
ccd configuration
Pull request that updates CCD definition configuration
docmosis
Pull requests that update Docmosis templates
enable_full_functional_tests
enable_keep_helm
enable_wa
ns:family-public-law
pr-values:wa
Enables WA in preview
prd:fpl
prod/add-or-update
rel:fpl-case-service-pr-5498
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/DFPL-2295
https://tools.hmcts.net/jira/browse/DFPL-2303
https://tools.hmcts.net/jira/browse/DFPL-2316
https://tools.hmcts.net/jira/browse/DFPL-2312
https://tools.hmcts.net/jira/browse/DFPL-2310
Change description
Feature branch for C110a tickets
Does this PR introduce a breaking change? (check one with "x")