Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DFPL-C110a C110a Feature Branch #5498

Draft
wants to merge 44 commits into
base: master
Choose a base branch
from
Draft

DFPL-C110a C110a Feature Branch #5498

wants to merge 44 commits into from

Conversation

qasimnawaz-moj
Copy link
Contributor

@qasimnawaz-moj qasimnawaz-moj commented Jul 10, 2024

JIRA link (if applicable)

https://tools.hmcts.net/jira/browse/DFPL-2295
https://tools.hmcts.net/jira/browse/DFPL-2303
https://tools.hmcts.net/jira/browse/DFPL-2316
https://tools.hmcts.net/jira/browse/DFPL-2312
https://tools.hmcts.net/jira/browse/DFPL-2310

Change description

Feature branch for C110a tickets

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[X] No

qasimnawaz-moj and others added 3 commits July 16, 2024 14:49
* DFPL-2295: c110a Design Changes to International Element

* Add default return statement

* Fix checkstyle

* Fix robotics tests

* Fix tests

* Update test resources

* Fix functional tests

* Update C110A template

* Fix old fields showing up in UI

* Update C110a template

* Add old fields to avoid deserialization issues

* Revert changes to 00095 doc

* Add CaseEventToComplexTypes for international element

* Fix bug with mandatory fields not being enforced

* Add international element notice

* Update styling

---------

Co-authored-by: jamesrferguson1 <[email protected]>
Co-authored-by: prabhamuthu15 <[email protected]>
@github-actions github-actions bot added docmosis Pull requests that update Docmosis templates ccd configuration Pull request that updates CCD definition configuration labels Jul 16, 2024
qasimnawaz-moj and others added 3 commits August 14, 2024 13:03
…Parenting Sections (#5492)

* DFPL-2295: c110a Design Changes to International Element

* Add default return statement

* Fix checkstyle

* Fix robotics tests

* Fix tests

* Update test resources

* Fix functional tests

* Update C110A template

* Fix old fields showing up in UI

* Update C110a template

* Add old fields to avoid deserialization issues

* Revert changes to 00095 doc

* Add CaseEventToComplexTypes for international element

* Fix bug with mandatory fields not being enforced

* Add international element notice

* Update styling

* DFPL-2303: c110a Design Changes to Risk and Harm & Factors Affecting Parenting Sections

* Fix typo

* Deprecate existing fields

* Make all fields in event mandatory

* Update models

* Update submission service

* Update robotics service

* Update Risk checker

* Add tests

* Remove whitespace

* Fix checkstyle

* Fix checkstyle

* Fix tests

* Update callback for testing

* Modify docmosis template and generation logic

* Re-add old fields

* Update tests

* Remove factorsParenting docmosis generation

* Fix tests

* Fix case details for tests

* Fix list bug

* Remove factors affecting parenting logic

* Uodate renderer logic

* Update task list rescources for tests

* Fix tests

* Remove import

* Fix issue with C110a doc generation

* Update test resources

* Fix case submission generation logic

* Fix tests

* remove unused function

* test update

* checkstyle

---------

Co-authored-by: jamesrferguson1 <[email protected]>
Co-authored-by: prabhamuthu15 <[email protected]>
* AddSystemUserPermissionToHearingPreferenceField

* courtserviceUiTest

* RemoveLogMsg
@hmcts-jenkins-d-to-i
Copy link
Contributor

Plan Result (aat)

Plan: 0 to add, 2 to change, 0 to destroy.
  • Update
    • azurerm_key_vault_secret.update-summary-tab-cron
    • module.fpl-action-group.azurerm_resource_group_template_deployment.action-group
Change Result (Click me)
  # azurerm_key_vault_secret.update-summary-tab-cron will be updated in-place
  ~ resource "azurerm_key_vault_secret" "update-summary-tab-cron" {
        id                      = "https://fpl-aat.vault.azure.net/secrets/update-summary-tab-cron/610e9d1fb33f446c9b8ee86a6a49b90b"
        name                    = "update-summary-tab-cron"
      - not_before_date         = "2023-11-22T08:32:40Z" -> null
        tags                    = {}
        # (7 unchanged attributes hidden)
    }

  # module.fpl-action-group.azurerm_resource_group_template_deployment.action-group will be updated in-place
  ~ resource "azurerm_resource_group_template_deployment" "action-group" {
        id                       = "/subscriptions/1c4f0704-a29e-403d-b719-b90c34ef14c9/resourceGroups/fpl-case-service-aat/providers/Microsoft.Resources/deployments/fpl-support"
        name                     = "fpl-support"
        tags                     = {}
      ~ template_content         = jsonencode(
          ~ {
              ~ outputs        = {
                  ~ actionGroupId = {
                      ~ type  = "String" -> "string"
                        # (1 unchanged attribute hidden)
                    }
                }
              ~ parameters     = {
                  ~ actionGroupName      = {
                      ~ type = "String" -> "string"
                    }
                  ~ emailReceiverAddress = {
                      ~ type     = "String" -> "string"
                        # (1 unchanged attribute hidden)
                    }
                  ~ emailReceiverName    = {
                      ~ type     = "String" -> "string"
                        # (1 unchanged attribute hidden)
                    }
                  ~ location             = {
                      ~ type         = "String" -> "string"
                        # (1 unchanged attribute hidden)
                    }
                  ~ shortName            = {
                      ~ type = "String" -> "string"
                    }
                }
                # (3 unchanged attributes hidden)
            }
        )
        # (6 unchanged attributes hidden)
    }

Plan: 0 to add, 2 to change, 0 to destroy.

@hmcts-jenkins-d-to-i
Copy link
Contributor

Plan Result (prod)

Plan: 0 to add, 6 to change, 0 to destroy.
  • Update
    • module.fpl-action-group.azurerm_resource_group_template_deployment.action-group
    • module.fpl-exceptions-alert.azurerm_resource_group_template_deployment.custom_alert[0]
    • module.fpl-health-failure-alert.azurerm_resource_group_template_deployment.custom_alert[0]
    • module.fpl-performance-alert.azurerm_resource_group_template_deployment.custom_alert[0]
    • module.fpl-summary-tab-job-alert.azurerm_resource_group_template_deployment.custom_alert[0]
    • module.fpl-upcoming-hearings-job-alert.azurerm_resource_group_template_deployment.custom_alert[0]
Change Result (Click me)
  # module.fpl-action-group.azurerm_resource_group_template_deployment.action-group will be updated in-place
  ~ resource "azurerm_resource_group_template_deployment" "action-group" {
        id                       = "/subscriptions/8999dec3-0104-4a27-94ee-6588559729d1/resourceGroups/fpl-case-service-prod/providers/Microsoft.Resources/deployments/fpl-support"
        name                     = "fpl-support"
        tags                     = {}
      ~ template_content         = jsonencode(
          ~ {
              ~ outputs        = {
                  ~ actionGroupId = {
                      ~ type  = "String" -> "string"
                        # (1 unchanged attribute hidden)
                    }
                }
              ~ parameters     = {
                  ~ actionGroupName      = {
                      ~ type = "String" -> "string"
                    }
                  ~ emailReceiverAddress = {
                      ~ type     = "String" -> "string"
                        # (1 unchanged attribute hidden)
                    }
                  ~ emailReceiverName    = {
                      ~ type     = "String" -> "string"
                        # (1 unchanged attribute hidden)
                    }
                  ~ location             = {
                      ~ type         = "String" -> "string"
                        # (1 unchanged attribute hidden)
                    }
                  ~ shortName            = {
                      ~ type = "String" -> "string"
                    }
                }
                # (3 unchanged attributes hidden)
            }
        )
        # (6 unchanged attributes hidden)
    }

  # module.fpl-exceptions-alert.azurerm_resource_group_template_deployment.custom_alert[0] will be updated in-place
  ~ resource "azurerm_resource_group_template_deployment" "custom_alert" {
        id                       = "/subscriptions/8999dec3-0104-4a27-94ee-6588559729d1/resourceGroups/fpl-case-service-prod/providers/Microsoft.Resources/deployments/fpl-exceptions"
        name                     = "fpl-exceptions"
        tags                     = {}
      ~ template_content         = jsonencode(
          ~ {
              ~ parameters     = {
                  ~ actionGroupName          = {
                      ~ type = "String" -> "string"
                    }
                  ~ actionGroupRg            = {
                      ~ type = "String" -> "string"
                    }
                  ~ alertDesc                = {
                      ~ type = "String" -> "string"
                    }
                  ~ alertName                = {
                      ~ type = "String" -> "string"
                    }
                  ~ appInsightsName          = {
                      ~ type = "String" -> "string"
                    }
                  ~ appInsightsQuery         = {
                      ~ type = "String" -> "string"
                    }
                  ~ commonTags               = {
                      ~ type = "String" -> "string"
                    }
                  ~ customEmailSubject       = {
                      ~ type = "String" -> "string"
                    }
                  ~ frequencyInMinutes       = {
                      ~ type         = "String" -> "string"
                        # (1 unchanged attribute hidden)
                    }
                  ~ location                 = {
                      ~ type = "String" -> "string"
                    }
                  ~ severityLevel            = {
                      ~ type         = "String" -> "string"
                        # (1 unchanged attribute hidden)
                    }
                  ~ timeWindowInMinutes      = {
                      ~ type         = "String" -> "string"
                        # (1 unchanged attribute hidden)
                    }
                  ~ triggerThreshold         = {
                      ~ type = "String" -> "string"
                    }
                  ~ triggerThresholdOperator = {
                      ~ type          = "String" -> "string"
                        # (2 unchanged attributes hidden)
                    }
                }
                # (4 unchanged attributes hidden)
            }
        )
        # (6 unchanged attributes hidden)
    }

  # module.fpl-health-failure-alert.azurerm_resource_group_template_deployment.custom_alert[0] will be updated in-place
  ~ resource "azurerm_resource_group_template_deployment" "custom_alert" {
        id                       = "/subscriptions/8999dec3-0104-4a27-94ee-6588559729d1/resourceGroups/fpl-case-service-prod/providers/Microsoft.Resources/deployments/fpl-health-failure"
        name                     = "fpl-health-failure"
        tags                     = {}
      ~ template_content         = jsonencode(
          ~ {
              ~ parameters     = {
                  ~ actionGroupName          = {
                      ~ type = "String" -> "string"
                    }
                  ~ actionGroupRg            = {
                      ~ type = "String" -> "string"
                    }
                  ~ alertDesc                = {
                      ~ type = "String" -> "string"
                    }
                  ~ alertName                = {
                      ~ type = "String" -> "string"
                    }
                  ~ appInsightsName          = {
                      ~ type = "String" -> "string"
                    }
                  ~ appInsightsQuery         = {
                      ~ type = "String" -> "string"
                    }
                  ~ commonTags               = {
                      ~ type = "String" -> "string"
                    }
                  ~ customEmailSubject       = {
                      ~ type = "String" -> "string"
                    }
                  ~ frequencyInMinutes       = {
                      ~ type         = "String" -> "string"
                        # (1 unchanged attribute hidden)
                    }
                  ~ location                 = {
                      ~ type = "String" -> "string"
                    }
                  ~ severityLevel            = {
                      ~ type         = "String" -> "string"
                        # (1 unchanged attribute hidden)
                    }
                  ~ timeWindowInMinutes      = {
                      ~ type         = "String" -> "string"
                        # (1 unchanged attribute hidden)
                    }
                  ~ triggerThreshold         = {
                      ~ type = "String" -> "string"
                    }
                  ~ triggerThresholdOperator = {
                      ~ type          = "String" -> "string"
                        # (2 unchanged attributes hidden)
                    }
                }
                # (4 unchanged attributes hidden)
            }
        )
        # (6 unchanged attributes hidden)
    }

  # module.fpl-performance-alert.azurerm_resource_group_template_deployment.custom_alert[0] will be updated in-place
  ~ resource "azurerm_resource_group_template_deployment" "custom_alert" {
        id                       = "/subscriptions/8999dec3-0104-4a27-94ee-6588559729d1/resourceGroups/fpl-case-service-prod/providers/Microsoft.Resources/deployments/fpl-performance"
        name                     = "fpl-performance"
        tags                     = {}
      ~ template_content         = jsonencode(
          ~ {
              ~ parameters     = {
                  ~ actionGroupName          = {
                      ~ type = "String" -> "string"
                    }
                  ~ actionGroupRg            = {
                      ~ type = "String" -> "string"
                    }
                  ~ alertDesc                = {
                      ~ type = "String" -> "string"
                    }
                  ~ alertName                = {
                      ~ type = "String" -> "string"
                    }
                  ~ appInsightsName          = {
                      ~ type = "String" -> "string"
                    }
                  ~ appInsightsQuery         = {
                      ~ type = "String" -> "string"
                    }
                  ~ commonTags               = {
                      ~ type = "String" -> "string"
                    }
                  ~ customEmailSubject       = {
                      ~ type = "String" -> "string"
                    }
                  ~ frequencyInMinutes       = {
                      ~ type         = "String" -> "string"
                        # (1 unchanged attribute hidden)
                    }
                  ~ location                 = {
                      ~ type = "String" -> "string"
                    }
                  ~ severityLevel            = {
                      ~ type         = "String" -> "string"
                        # (1 unchanged attribute hidden)
                    }
                  ~ timeWindowInMinutes      = {
                      ~ type         = "String" -> "string"
                        # (1 unchanged attribute hidden)
                    }
                  ~ triggerThreshold         = {
                      ~ type = "String" -> "string"
                    }
                  ~ triggerThresholdOperator = {
                      ~ type          = "String" -> "string"
                        # (2 unchanged attributes hidden)
                    }
                }
                # (4 unchanged attributes hidden)
            }
        )
        # (6 unchanged attributes hidden)
    }

  # module.fpl-summary-tab-job-alert.azurerm_resource_group_template_deployment.custom_alert[0] will be updated in-place
  ~ resource "azurerm_resource_group_template_deployment" "custom_alert" {
        id                       = "/subscriptions/8999dec3-0104-4a27-94ee-6588559729d1/resourceGroups/fpl-case-service-prod/providers/Microsoft.Resources/deployments/fpl-summary-tab-job-failure"
        name                     = "fpl-summary-tab-job-failure"
        tags                     = {}
      ~ template_content         = jsonencode(
          ~ {
              ~ parameters     = {
                  ~ actionGroupName          = {
                      ~ type = "String" -> "string"
                    }
                  ~ actionGroupRg            = {
                      ~ type = "String" -> "string"
                    }
                  ~ alertDesc                = {
                      ~ type = "String" -> "string"
                    }
                  ~ alertName                = {
                      ~ type = "String" -> "string"
                    }
                  ~ appInsightsName          = {
                      ~ type = "String" -> "string"
                    }
                  ~ appInsightsQuery         = {
                      ~ type = "String" -> "string"
                    }
                  ~ commonTags               = {
                      ~ type = "String" -> "string"
                    }
                  ~ customEmailSubject       = {
                      ~ type = "String" -> "string"
                    }
                  ~ frequencyInMinutes       = {
                      ~ type         = "String" -> "string"
                        # (1 unchanged attribute hidden)
                    }
                  ~ location                 = {
                      ~ type = "String" -> "string"
                    }
                  ~ severityLevel            = {
                      ~ type         = "String" -> "string"
                        # (1 unchanged attribute hidden)
                    }
                  ~ timeWindowInMinutes      = {
                      ~ type         = "String" -> "string"
                        # (1 unchanged attribute hidden)
                    }
                  ~ triggerThreshold         = {
                      ~ type = "String" -> "string"
                    }
                  ~ triggerThresholdOperator = {
                      ~ type          = "String" -> "string"
                        # (2 unchanged attributes hidden)
                    }
                }
                # (4 unchanged attributes hidden)
            }
        )
        # (6 unchanged attributes hidden)
    }

  # module.fpl-upcoming-hearings-job-alert.azurerm_resource_group_template_deployment.custom_alert[0] will be updated in-place
  ~ resource "azurerm_resource_group_template_deployment" "custom_alert" {
        id                       = "/subscriptions/8999dec3-0104-4a27-94ee-6588559729d1/resourceGroups/fpl-case-service-prod/providers/Microsoft.Resources/deployments/fpl-upcoming-hearings-job-failure"
        name                     = "fpl-upcoming-hearings-job-failure"
        tags                     = {}
      ~ template_content         = jsonencode(
          ~ {
              ~ parameters     = {
                  ~ actionGroupName          = {
                      ~ type = "String" -> "string"
                    }
                  ~ actionGroupRg            = {
                      ~ type = "String" -> "string"
                    }
                  ~ alertDesc                = {
                      ~ type = "String" -> "string"
                    }
                  ~ alertName                = {
                      ~ type = "String" -> "string"
                    }
                  ~ appInsightsName          = {
                      ~ type = "String" -> "string"
                    }
                  ~ appInsightsQuery         = {
                      ~ type = "String" -> "string"
                    }
                  ~ commonTags               = {
                      ~ type = "String" -> "string"
                    }
                  ~ customEmailSubject       = {
                      ~ type = "String" -> "string"
                    }
                  ~ frequencyInMinutes       = {
                      ~ type         = "String" -> "string"
                        # (1 unchanged attribute hidden)
                    }
                  ~ location                 = {
                      ~ type = "String" -> "string"
                    }
                  ~ severityLevel            = {
                      ~ type         = "String" -> "string"
                        # (1 unchanged attribute hidden)
                    }
                  ~ timeWindowInMinutes      = {
                      ~ type         = "String" -> "string"
                        # (1 unchanged attribute hidden)
                    }
                  ~ triggerThreshold         = {
                      ~ type = "String" -> "string"
                    }
                  ~ triggerThresholdOperator = {
                      ~ type          = "String" -> "string"
                        # (2 unchanged attributes hidden)
                    }
                }
                # (4 unchanged attributes hidden)
            }
        )
        # (6 unchanged attributes hidden)
    }

Plan: 0 to add, 6 to change, 0 to destroy.

@hmcts-jenkins-d-to-i hmcts-jenkins-d-to-i bot requested a deployment to preview January 28, 2025 12:49 Abandoned
@hmcts-jenkins-d-to-i hmcts-jenkins-d-to-i bot requested a deployment to preview January 29, 2025 10:53 Abandoned
@hmcts-jenkins-d-to-i hmcts-jenkins-d-to-i bot requested a deployment to preview January 29, 2025 11:34 Abandoned
@hmcts-jenkins-d-to-i hmcts-jenkins-d-to-i bot requested a deployment to preview January 29, 2025 12:42 Abandoned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants