Dfpl 2439 query collections #5582
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ccd configuration
updating image of xui-webapp for testing.
updating correct xui-mc image for QA
qasimnawaz-moj
added
pr-values:wa
jamesrferguson1
commented
Jan 28, 2025
| @@ -53,7 +53,7 @@ xui-webapp: | |||
| imagePullPolicy: Always | |||
| replicas: 1 | |||
| releaseNameOverride: ${SERVICE_NAME}-xui-webapp | |||
| image: hmctspublic.azurecr.io/xui/webapp:latest | |||
| image: hmctspublic.azurecr.io/xui/webapp:pr-4140-dc9226f-20250113180116 | |||
There was a problem hiding this comment.
guess will need to remember to take this out when we're done testing
Comment on lines
+71
to
+76
| private void logQueryCollection(CaseDetails caseDetails, String collectionKey) { | ||
| if (caseDetails.getData().containsKey(collectionKey)) { | ||
| log.info("{} is present with value: {}", collectionKey, caseDetails.getData().get(collectionKey)); | ||
| } else { | ||
| log.info("{} is not present on case data.", collectionKey); | ||
| } |
There was a problem hiding this comment.
logging will need to be removed before deployment, as field contents may contain PII.
| @@ -156,7 +156,7 @@ def deployWADmns() { | |||
|
|
|||
| def waStandaloneBranch = "master" | |||
| // For testing DMNs, change this to the branch on the DMN repo, but ensure it is changed back to master before merging | |||
| def dmnBranch = "master" | |||
| def dmnBranch = "DFPL-2439-v2" | |||
There was a problem hiding this comment.
just a note to remove before deployment!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/DFPL-2439
Change description
Adding query collections for case management.
Does this PR introduce a breaking change? (check one with "x")