Correct and enhance US holiday definitions #54
Conversation
spaceneedle2019
commented
Jun 20, 2017
•
spaceneedle2019
commented
- Add missing holiday information for a whole bunch of US states (now 54 in total!)
- Correct some existing holiday information
- Add custom functions for Georgia’s State Holiday, Lee-Jackson Day and Election Day
- Add custom functions for Rosh Hashanah and Yom Kippur with pre-defined dates from 2014 to 2020
- Add (missing) tests and correct existing tests
- Add helpful comments
- Add a lot of used sources
- Add missing holiday information for a whole bunch of US states - Correct some existing holiday information - Add custom functions for Georgia’s State Holiday, Lee-Jackson Day and Election Day - Add custom functions for Rosh Hashanah and Yom Kippur with pre-defined dates from 2014 to 2020 - Add missing tests and correct existing tests - Add helpful comments - Add a lot of used sources
Both are not observed.
+ Add new method for Christmas Eve Holiday
There was a problem hiding this comment.
Looks good! I have questions about some custom methods but we can discuss them after I merge.
Would you mind maybe creating an issue that references this so I won't forget? Just link to the two holidays and say something like 'we would like this to be calculated so it will not break after 2020'. Simple is totally fine. 👍
| rosh_hashanah: | ||
| arguments: year | ||
| source: | | ||
| rosh_hashanah_dates = { |
There was a problem hiding this comment.
I generally don't mind custom functions but this seems like a time bomb that I will surely forget about by 2020. 😄
Is there a way to calculate Rosh Hashanah? Maybe we should add it into the available 'functions' over in rubyland.
That said, having it now is better than not having it so I'm going to totally accept this. 😄
There was a problem hiding this comment.
Yeah, I agree with you. It's similar to Ramadan and Sacrifice Feast in the Turkish calendar (see #55). In addition to a calculation we need a transformation from the Hebrew into the Gregorian calendar to generate the dates for Rosh Hashanah and Yom Kippur.
https://en.wikipedia.org/wiki/Jewish_and_Israeli_holidays_2000–2050
| yom_kippur: | ||
| arguments: year | ||
| source: | | ||
| yom_kippur_dates = { |
There was a problem hiding this comment.
Same question about calculation. Is it possible to calculate Yom Kippur?
