-
-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enh(dev): Don't force holoviews to be installed for test-example and docs-build #6497
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6497 +/- ##
=======================================
Coverage 88.79% 88.79%
=======================================
Files 323 323
Lines 68731 68731
=======================================
Hits 61028 61028
Misses 7703 7703 ☔ View full report in Codecov by Sentry. |
system = platform.system() | ||
py_version = sys.version_info[:2] | ||
PANDAS_GE_2_0_0 = Version(pd.__version__).release >= (2, 0, 0) | ||
|
||
# Having "OMP_NUM_THREADS"=1, set as an environment variable, can be needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is currently set in the pixi_install task and no longer in the test.yaml itself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wondering if prefixing the commands (pytest ...
, nbsite ...
) with python -m
wouldn't do the trick?
FWIW I've done it a bit differently in hvPlot with the following as I prefer to make sure the package is installed.
[feature.required.tasks]
download-data = 'python scripts/download_data.py'
install = 'python -m pip install --no-deps --disable-pip-version-check -e .'
install-dev = { cmd = "pre-commit install", depends-on = ["install", "download-data"] }
and
[feature.doc.tasks]
docs-build = 'sphinx-build -b html doc builtdocs'
# docs-build-dev = { cmd = "pre-commit install", depends-on = ["install", "docs-build"] }
_docs-install = 'python -m pip install --no-deps --disable-pip-version-check -e .'
docs-build-dev = { depends-on = ["_docs-install", "docs-build"] }
I tested it locally, and it did not do the trick.
I like the idea behind the I don't like |
Right now, if we want to
pixi run test-example
andpixi run docs-build
, it will fail because 'HoloViews' is not installed, and for new developers give a weird error message likeholoviews is not installed
. It is stated in the docs that you need to runpixi run install
before doing anything, but people forget or don't read the docs.I can't currently think of a reason why this should be done, as holoviews is doing anything weird as installing/downloading doing the build step.