Set ciphers to DEFAULT in socket_client.py to connect with a wider range of chromecast devices #990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add context.set_ciphers('DEFAULT') to allow older ciphers to work
|
Please motivate why this change is needed |
|
HI @emontnemery! As described in #963, there is at least one closed-source chromecast client that is using older ciphers that fail connection attempts as-is. I wouldn't say it's needed, but personally, it would be nice to not have to edit this file every time a new home assistant container is deployed. Thanks, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add context.set_ciphers('DEFAULT') to allow older ciphers to work