Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed "ticktick_todo" to "ticktick" #6381

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Hantick
Copy link

@Hantick Hantick commented Jan 16, 2025

Proposed change

TickTick has become a bigger software than just a todo list, it offers calendar, kanban planning and many more and I think that ticktick_todo name for that brand is invalid, in my opinion it should be named as ticktick as this is the official name of the brand and that one should be followed.

Type of change

  • Add a new logo or icon for a new core integration
  • Add a missing icon or logo for an existing core integration
  • Add a new logo or icon for a custom integration (custom component)
  • Replace an existing icon or logo with a higher quality version
  • Replace an existing icon or logo after a branding change
  • Removing an icon or logo

Additional information

  • This PR fixes or closes issue: fixes #
  • Link to code base pull request:
  • Link to documentation pull request:
  • Link to integration documentation on our website:
  • Link to custom integration repository:

Checklist

  • The added/replaced image(s) are PNG
  • Icon image size is 256x256px (icon.png)
  • hDPI icon image size is 512x512px for ([email protected])
  • Logo image size has min 128px, but max 256px, on the shortest side (logo.png)
  • hDPI logo image size has min 256px, but max 512px, on the shortest side ([email protected])

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will collide in domain name with the core integration that is currently in the process of being added here:

home-assistant/core#118871

../Frenck

@home-assistant home-assistant bot marked this pull request as draft January 19, 2025 18:25
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@Hantick
Copy link
Author

Hantick commented Jan 19, 2025

This will collide in domain name with the core integration that is currently in the process of being added here:

home-assistant/core#118871

../Frenck

I'll contact with @arne182

@Hantick
Copy link
Author

Hantick commented Jan 20, 2025

@frenck Arne closed his PR, I would like to create this integration as a custom one and later on after some testing and polishing the integration to the bugless state I would create the PR against the core

@frenck
Copy link
Member

frenck commented Jan 20, 2025

If that is the intention, I would still advise against the domain change, as you are now planning towards a future domain collision.

../Frenck

@Hantick
Copy link
Author

Hantick commented Jan 20, 2025

@frenck I understand it, I will change the domain to ticktick_todo and post it to the HACS official repository, later on I will add tests and make integration bulletproof and eventually will post it as ticktick to the Core. Does that makes sense or I'm missing something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants