Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document manual_only option for addon boot mode #2286

Merged
merged 2 commits into from
Aug 27, 2024

Conversation

mdegat01
Copy link
Contributor

@mdegat01 mdegat01 commented Aug 26, 2024

Proposed change

Document new manual_only option added for addon boot mode added in home-assistant/supervisor#5272

Type of change

  • Document existing features within Home Assistant
  • Document new or changing features which there is an existing pull request elsewhere
  • Spelling or grammatical corrections, or rewording for improved clarity
  • Changes to the backend of this documentation
  • Removed stale or deprecated documentation

Additional information

Summary by CodeRabbit

Summary by CodeRabbit

  • New Features
    • Expanded documentation for the boot configuration option in add-ons, clarifying the use of manual_only to prevent automatic starts.
    • Introduced a new field, boot_config, in the API documentation, allowing for more precise control over add-on boot behavior.

@mdegat01 mdegat01 requested review from agners and frenck August 26, 2024 20:23
Copy link
Contributor

coderabbitai bot commented Aug 26, 2024

Walkthrough

Walkthrough

The changes enhance the Home Assistant add-on configuration by updating the boot option description to include a new value, manual_only, which prevents automatic starts at boot. Additionally, a new field, boot_config, has been introduced in the API documentation and response, allowing for a more precise specification of an add-on's boot mode.

Changes

File Change Summary
docs/add-ons/configuration.md Updated the boot configuration option description to include manual_only, clarifying its functionality and control over automatic starts.
docs/api/supervisor/endpoints.md Introduced a new field, boot_config, to represent the default boot mode of an add-on, enhancing the API's ability to specify boot behavior.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Add-on
    participant System

    User->>System: Request add-on configuration
    System->>Add-on: Retrieve boot configuration
    Add-on-->>System: Return boot_config value
    System-->>User: Display boot_config
Loading
sequenceDiagram
    participant User
    participant Add-on
    participant System

    User->>System: Set boot option to manual_only
    System->>Add-on: Update boot configuration
    Add-on-->>System: Confirm update
    System-->>User: Boot option updated
Loading

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 251db8f and 0a5f9b0.

Files selected for processing (2)
  • docs/add-ons/configuration.md (1 hunks)
  • docs/api/supervisor/endpoints.md (2 hunks)
Files skipped from review as they are similar to previous changes (1)
  • docs/api/supervisor/endpoints.md
Additional context used
LanguageTool
docs/add-ons/configuration.md

[uncategorized] ~144-~144: Possible missing article found.
Context: ... add-on to only be started manually. If addon should never be started at boot automat...

(AI_HYDRA_LEO_MISSING_THE)

Markdownlint
docs/add-ons/configuration.md

144-144: Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
Table pipe style

(MD055, table-pipe-style)


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

docs/add-ons/configuration.md Outdated Show resolved Hide resolved
@mdegat01 mdegat01 changed the title Document manual_forced option for addon boot mode Document manual_only option for addon boot mode Aug 27, 2024
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Outside diff range, codebase verification and nitpick comments (1)
docs/add-ons/configuration.md (1)

144-144: Improve readability and correctness.

Add a comma after "system," add "the" before "addon," and add a trailing pipe to the table for consistency.

Apply this diff to improve readability and correctness:

-| `boot` | string | `auto` | `auto` start at boot is controlled by the system and `manual` configures the add-on to only be started manually. If addon should never be started at boot automatically, use `manual_only` to prevent users from changing it.
+| `boot` | string | `auto` | `auto` start at boot is controlled by the system, and `manual` configures the add-on to only be started manually. If the addon should never be started at boot automatically, use `manual_only` to prevent users from changing it. |
Tools
LanguageTool

[uncategorized] ~144-~144: Possible missing article found.
Context: ... add-on to only be started manually. If addon should never be started at boot automat...

(AI_HYDRA_LEO_MISSING_THE)

Markdownlint

144-144: Expected: leading_and_trailing; Actual: leading_only; Missing trailing pipe
Table pipe style

(MD055, table-pipe-style)

@agners agners merged commit 3a4a8f4 into master Aug 27, 2024
4 checks passed
@agners agners deleted the addon-disable-boot-at-startup branch August 27, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants