Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ha-tabs chevrons bug #17620

Merged
merged 1 commit into from
Aug 18, 2023

Conversation

RoboMagus
Copy link
Contributor

Proposed change

As #16091 has not been touched since the issue was first created 4 releases ago, this proposes a workaround to fix the bug of scrolling chevrons appearing on the ha-tabs bar when they are not required. This is done by calling the scroll handling functions when the tabs are changed (populated).

This also fixes a non-reported bug that may occur in edge cases where by selecting a partially visible tab that causes the ha-tabs container to scroll that item into view, the chevrons are not updated while they should be, as now tabs have scrolled out of sight.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bramkragten
Copy link
Member

Thanks!

@bramkragten bramkragten enabled auto-merge (squash) August 18, 2023 12:55
@bramkragten bramkragten merged commit 38a317b into home-assistant:dev Aug 18, 2023
@RoboMagus RoboMagus deleted the fix_ha_tabs_chevrons branch August 22, 2023 12:55
@github-actions github-actions bot locked and limited conversation to collaborators Aug 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hard or soft reloading of the page adds chevrons to the header when they are not needed.
2 participants