Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix keyboard for ha-config-entities bulk menus #23776

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

karwosts
Copy link
Contributor

@karwosts karwosts commented Jan 17, 2025

Proposed change

Fix some of the menus in ha-config-entities, which are not usable via keyboard (impossible to select options without a mouse):

  • Bulk Actions Menu
  • Bulk Label Menu - this one is still a little weird as the row has a tabstop both on the individual label rows and on their child checkbox. Pressing space/return on the row does nothing, but pressing space on the checkbox does work, so I'll not propose any change as it is still technically possible to use, but I'm not confident what the best practice here would be.

Following pattern agreed in previous PR #21048

Also just leaving a note of what still doesn't work w/ keyboard (but are handled in different files, I guess ha-data-table):

  • Select All/None menu doesn't work
  • Entire filters subpanel doesn't work
  • Group by doesn't work
  • Sort by doesn't work
  • Customize dialog doesn't work

Other pages that likely have similar issues as this one (just by cursory glance), that may also need similar fixes:

  • ha-automation-picker
  • ha-scene-dashboard
  • ha-config-integration-page
  • ha-config-devices-dashboard
  • ha-config-helpers
  • ha-script-picker

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@karwosts karwosts added the Accessibility Related to accessibility for people with disabilities label Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accessibility Related to accessibility for people with disabilities cla-signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Entities bulk action menu not keyboard accessible
1 participant