Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Fix docker config restore in corner case #5601

Closed
wants to merge 1 commit into from

Conversation

agners
Copy link
Member

@agners agners commented Feb 4, 2025

Proposed change

Store Docker config per location to fix corner case (when encrypted and unencrypted backup get consolidated).

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (which adds functionality to the supervisor)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to cli pull request:
  • Link to client library pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Ruff (ruff format supervisor tests)
  • Tests have been added to verify that the new code works.

If API endpoints or add-on configuration are added/changed:

Store Docker config per location to fix corner case (when encrypted
and unencrypted backup get consolidated).
@agners agners added the bugfix A bug fix label Feb 4, 2025
@agners agners marked this pull request as draft February 4, 2025 16:55
@agners
Copy link
Member Author

agners commented Feb 5, 2025

Let's drop the current Docker registry configuration from Backup feature for now (#5605). It is most likely very seldom used. Users can work around by configuring the Docker registry settings before restoring the backup manually.

@agners agners closed this Feb 5, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Feb 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant