Remove regex requirement #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
davidgraeff
commented
Apr 27, 2018
davidgraeff
commented
- A good regex parser is not lightweight and most likely needs lots of heap memory for the state machine and backreferences and whatnot. Do not make it mandatory to support it.
- Be more precise when the property format attribute is required
* A good regex parser is not lightweight and most likely needs lots of heap memory for the state machine and backreferences and whatnot. Do not make it mandatory to support it. * Be more precise when the property format attribute is required
|
I have to agree, it's not that useful anyway. Never had to use it in practice. It does not break semver, so it does not harm. @timpur @euphi @ThomDietrich LGTM? |
|
Fine with me 👍 |
|
All for !!! |
|
Thanks guys! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.