Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(jsx): export ComponentWithChildren type #3758

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
export ComponentWithChildren type
yasuaki640 committed Dec 19, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit cee75d6784583672c8f20f71a490e87b9c05fbf0
2 changes: 1 addition & 1 deletion src/middleware/jsx-renderer/index.ts
Original file line number Diff line number Diff line change
@@ -25,7 +25,7 @@ type Component = (
c: Context
) => HtmlEscapedString | Promise<HtmlEscapedString>

type ComponentWithChildren = (
export type ComponentWithChildren = (
props: PropsWithChildren<PropsForRenderer & { Layout: FC }>,
c: Context
) => HtmlEscapedString | Promise<HtmlEscapedString>

Unchanged files with check annotations Beta

}
protected getHeaders(event: APIGatewayProxyEvent): Headers {
const headers = new Headers()

Check failure on line 344 in src/adapter/aws-lambda/handler.ts

GitHub Actions / Node.js v22.x

'event' is declared but its value is never read.

Check failure on line 344 in src/adapter/aws-lambda/handler.ts

GitHub Actions / Node.js v20.x

'event' is declared but its value is never read.

Check failure on line 344 in src/adapter/aws-lambda/handler.ts

GitHub Actions / Node.js v18.18.2

'event' is declared but its value is never read.

Check failure on line 344 in src/adapter/aws-lambda/handler.ts

GitHub Actions / workerd

'event' is declared but its value is never read.

Check failure on line 344 in src/adapter/aws-lambda/handler.ts

GitHub Actions / Main

'event' is declared but its value is never read.

Check failure on line 344 in src/adapter/aws-lambda/handler.ts

GitHub Actions / Node.js v22.x

'event' is declared but its value is never read.

Check failure on line 344 in src/adapter/aws-lambda/handler.ts

GitHub Actions / Node.js v18.18.2

'event' is declared but its value is never read.

Check failure on line 344 in src/adapter/aws-lambda/handler.ts

GitHub Actions / workerd

'event' is declared but its value is never read.

Check failure on line 344 in src/adapter/aws-lambda/handler.ts

GitHub Actions / Node.js v20.x

'event' is declared but its value is never read.

Check failure on line 344 in src/adapter/aws-lambda/handler.ts

GitHub Actions / Main

'event' is declared but its value is never read.
this.getCookies(event, headers)
if (event.headers) {

Check failure on line 346 in src/adapter/aws-lambda/handler.ts

GitHub Actions / Node.js v22.x

'headers' is declared but its value is never read.

Check failure on line 346 in src/adapter/aws-lambda/handler.ts

GitHub Actions / Node.js v20.x

'headers' is declared but its value is never read.

Check failure on line 346 in src/adapter/aws-lambda/handler.ts

GitHub Actions / Node.js v18.18.2

'headers' is declared but its value is never read.

Check failure on line 346 in src/adapter/aws-lambda/handler.ts

GitHub Actions / workerd

'headers' is declared but its value is never read.

Check failure on line 346 in src/adapter/aws-lambda/handler.ts

GitHub Actions / Main

'headers' is declared but its value is never read.

Check failure on line 346 in src/adapter/aws-lambda/handler.ts

GitHub Actions / Node.js v22.x

'headers' is declared but its value is never read.

Check failure on line 346 in src/adapter/aws-lambda/handler.ts

GitHub Actions / Node.js v18.18.2

'headers' is declared but its value is never read.

Check failure on line 346 in src/adapter/aws-lambda/handler.ts

GitHub Actions / workerd

'headers' is declared but its value is never read.

Check failure on line 346 in src/adapter/aws-lambda/handler.ts

GitHub Actions / Node.js v20.x

'headers' is declared but its value is never read.

Check failure on line 346 in src/adapter/aws-lambda/handler.ts

GitHub Actions / Main

'headers' is declared but its value is never read.
for (const [k, v] of Object.entries(event.headers)) {
if (v) {
headers.set(k, v)
}
type ReactNode = ReactElement | string | number | boolean | null | undefined
// eslint-disable-next-line @typescript-eslint/no-unused-vars
type ComponentClass<P = {}, S = {}> = unknown

Check failure on line 26 in src/jsx/types.ts

GitHub Actions / Node.js v22.x

All type parameters are unused.

Check failure on line 26 in src/jsx/types.ts

GitHub Actions / Node.js v20.x

All type parameters are unused.

Check failure on line 26 in src/jsx/types.ts

GitHub Actions / Node.js v18.18.2

All type parameters are unused.

Check failure on line 26 in src/jsx/types.ts

GitHub Actions / workerd

All type parameters are unused.

Check failure on line 26 in src/jsx/types.ts

GitHub Actions / Main

All type parameters are unused.

Check failure on line 26 in src/jsx/types.ts

GitHub Actions / Node.js v22.x

All type parameters are unused.

Check failure on line 26 in src/jsx/types.ts

GitHub Actions / Node.js v18.18.2

All type parameters are unused.

Check failure on line 26 in src/jsx/types.ts

GitHub Actions / workerd

All type parameters are unused.

Check failure on line 26 in src/jsx/types.ts

GitHub Actions / Node.js v20.x

All type parameters are unused.

Check failure on line 26 in src/jsx/types.ts

GitHub Actions / Main

All type parameters are unused.
export type { ReactElement, ReactNode, ComponentClass }