Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(context): remove lint errors #3769

Merged
merged 2 commits into from
Dec 25, 2024

Conversation

yusukebe
Copy link
Member

@yusukebe yusukebe commented Dec 25, 2024

Fixed that my IDE threw the errors with the current code.

CleanShot 2024-12-25 at 18 22 24@2x

The author should do the following, if applicable

  • Add tests
  • Run tests
  • bun run format:fix && bun run lint:fix to format the code
  • Add TSDoc/JSDoc to document the code

This comment has been minimized.

Copy link

Bundle size check

main (bfd839a) #3769 (b73248c) +/-
Bundle Size (B) 18,772B 18,772B 0B
Bundle Size (KB) 18.33K 18.33K 0K

Compiler Diagnostics

main (bfd839a) #3769 (b73248c) +/-
Files 256 256 0
Lines 115,029 115,031 2
Identifiers 111,978 111,978 0
Symbols 243,490 243,490 0
Types 204,698 204,698 0
Instantiations 3,044,219 3,044,219 0
Memory used 419,771K 420,758K 987K
I/O read 0.02s 0.02s 0s
I/O write 0s 0s 0s
Parse time 0.81s 0.85s 0.04s
Bind time 0.33s 0.32s -0.01s
Check time 5.24s 5.28s 0.04s
Emit time 0s 0s 0s
Total time 6.38s 6.44s 0.06s

Reported by octocov

Copy link

codecov bot commented Dec 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.72%. Comparing base (bfd839a) to head (27c9f0c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3769   +/-   ##
=======================================
  Coverage   91.72%   91.72%           
=======================================
  Files         159      159           
  Lines       10174    10175    +1     
  Branches     2896     2883   -13     
=======================================
+ Hits         9332     9333    +1     
  Misses        841      841           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yusukebe yusukebe merged commit b1335f9 into main Dec 25, 2024
16 checks passed
@yusukebe yusukebe deleted the refactor/context-remove-lint-errors branch December 25, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant