Optimize generating project data #2214
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
enhancement
for more information, see https://pre-commit.ci
spwoodcock
requested changes
Feb 19, 2025
| for f in batch | ||
| ] | ||
|
|
||
| async with db.cursor() as cur: |
There was a problem hiding this comment.
This will open a cursor for every feature in the project surely, as it's in the for loop?
There was a problem hiding this comment.
The previous approach inserted the featcol all in one go I think
There was a problem hiding this comment.
yeah you are right i can change that to use one cursor for all the batches.
| @@ -353,43 +311,31 @@ def add_required_geojson_properties( | |||
| This step is required prior to flatgeobuf generation, | |||
| else the workflows of conversion between the formats will fail. | |||
| """ | |||
| for feature in geojson.get("features", []): | |||
| properties = feature.get("properties", {}) | |||
| current_timestamp = datetime.now().strftime("%Y-%m-%dT%H:%M:%S") | |||
There was a problem hiding this comment.
We have a helper function from postgis_utils timestamp() that returns a current timezone aware timestamp in UTC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related Issue
Describe this PR
Screenshots
N/A
Alternative Approaches Considered
Did you attempt any other approaches that are not documented in code?
Review Guide
Notes for the reviewer. How to test this change?
Checklist before requesting a review
[optional] What gif best describes this PR or how it makes you feel?