Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to node 18 #1712

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Update to node 18 #1712

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7ae9352
Update to node 18
wwahammy Mar 24, 2024
f2e992d
Try updating webpack
wwahammy Mar 24, 2024
78e6580
Add webpack-cli to try to build?
wwahammy Apr 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/code-scanning.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ concurrency:
cancel-in-progress: true
env:
# this version used for running various tools
tool_node_version: "16.x"
tool_node_version: "18.x"
tool_ruby_version: "2.7.8"
jobs:
eslint:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,5 +18,5 @@ jobs:
matrix:
os: [ubuntu-20.04]
ruby: [2.7.8]
node: [16.x]
node: [18.x]

2 changes: 1 addition & 1 deletion .github/workflows/single-matrix-pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ on:
type: string
env:
# this version used for running various tools
tool_node_version: "16.x"
tool_node_version: "18.x"
tool_ruby_version: "2.7.8"
jobs:
changes:
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
16
18

2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ apt install curl -yy
#### Node and Yarn install

```bash
curl -sL https://deb.nodesource.com/setup_16.x | bash -
curl -sL https://deb.nodesource.com/setup_18.x | bash -
curl -sS https://dl.yarnpkg.com/debian/pubkey.gpg | apt-key add -
echo "deb https://dl.yarnpkg.com/debian/ stable main" | tee /etc/apt/sources.list.d/yarn.list
apt update
Expand Down
2 changes: 1 addition & 1 deletion docs/getting_started_wsl2.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ apt install curl -yy
#### Node and Yarn install

```bash
curl -sL https://deb.nodesource.com/setup_16.x | bash -
curl -sL https://deb.nodesource.com/setup_18.x | bash -
curl -sS https://dl.yarnpkg.com/debian/pubkey.gpg | apt-key add -
echo "deb https://dl.yarnpkg.com/debian/ stable main" | tee /etc/apt/sources.list.d/yarn.list
apt update
Expand Down
2 changes: 2 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,8 @@
"storybook-addon-intl": "^2.4.1",
"tiny-warning": "^1.0.3",
"typescript": "^5",
"webpack": "^5",
"webpack-cli": "^5.1.4",
"webpack-dev-server": "^3"
},
"dependencies": {
Expand Down
2 changes: 1 addition & 1 deletion script/build/debian/node.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#!/usr/bin/env bash
set -e
curl -sL https://deb.nodesource.com/setup_16.x | bash -
curl -sL https://deb.nodesource.com/setup_18.x | bash -
curl -sS https://dl.yarnpkg.com/debian/pubkey.gpg | apt-key add -
echo "deb https://dl.yarnpkg.com/debian/ stable main" | tee /etc/apt/sources.list.d/yarn.list

Expand Down
417 changes: 416 additions & 1 deletion yarn.lock
View file
Open in desktop

Large diffs are not rendered by default.

Loading