-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Divided contributor lists! #553
Draft
towerofnix
wants to merge
9
commits into
preview
Choose a base branch
from
contribs2
base: preview
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 17, 2024
Draft
towerofnix
force-pushed
the
contribs2
branch
from
September 26, 2024 10:19
c41c80a
to
1683ae0
Compare
towerofnix
force-pushed
the
contribs2
branch
3 times, most recently
from
October 5, 2024 13:51
8aa8815
to
3dc9fac
Compare
towerofnix
force-pushed
the
contribs2
branch
3 times, most recently
from
November 20, 2024 23:57
4dfc9e3
to
6f08eb9
Compare
This might be a crude implementation, but keeps language results from including {_: 'some string...'} objects that don't have any other keys, even when preventing so causes a mismatch with the reference spec/layout. (Of course, the "mismatch" is only presentationally and not semantically, and we already make other presentational differences because we output JSON and not YAML in this function.)
towerofnix
force-pushed
the
contribs2
branch
from
December 29, 2024 03:23
6f08eb9
to
4dc27c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft pull request. Some of these changes are fairly old! Subject to change, too.
Contributors
to mean "general contributors", and adds new fieldsWriting Contributors
,Performing Contributors
, andEngineering Contributors
.Writing Contributors
orPerforming Contributors
.Contributors
andEngineering Contributors
.Pending about a million data changes.