Classifier region #766
Merged
Classifier region #766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctrl-z-9000-times
approved these changes
Dec 22, 2019
|
Thanks for the review. |
breznak
reviewed
Jan 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ClassifierRegion is a new built-in Region for the SDRClassifier algorithm.
Reference Issue #761
Ok, guys, check this carefully to make sure I understood how the SDRClassifier works and implemented it correctly.
This should work with both the RDSE Encoder and the Scaler Encoder.
Note that I had to add a bucket output to the RDSERegion in order to have something for the ClassifierRegion to learn. The values are the quantized input rather than an index so the ClassifierRegion does not need to know what radius was used by the encoder and it can handle negative numbers.
I tried it with doubles and Categories. This classifier would also work with the Document encoder if we used some sort of external table of text values. The index would be the bucket value.