Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provide pronunciation in languages #2

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

provide pronunciation in languages #2

wants to merge 2 commits into from

Conversation

benjamine
Copy link

this will let you obtain a link to listen pronunciation, supports language auto-detection

@bkeepers
Copy link
Contributor

bkeepers commented Jun 4, 2015

This is cool. Would you be willing to merge the latest from master? Thanks!

@beneidel
provide pronunciation in languages
ac54f26 
this will let you obtain a link to listen pronunciation, supports language auto-detection
@benjamine
Copy link
Author

ok, rebased

@bkeepers
Copy link
Contributor

bkeepers commented Jun 4, 2015

This doesn't seem to work for me. I'm guessing suffers from the same API changes required in #4

@bkeepers
Copy link
Contributor

bkeepers commented Jun 4, 2015

Here's the output I get when it ry to run it. Note that nothing comes back from the last command.

hubot> hubot help pronounce
hubot pronounce <phrase> in <language> - Provides pronounciation of <phrase> (<language> is optional)
hubot> hubot pronounce bueno in spanish
hubot>

technicalpickles
technicalpickles reviewed Jun 5, 2015
View reviewed changes
src/google-translate.coffee


pattern = new RegExp('pronounce ' +
'(.*?)' +
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking this was being too greedy, but .*? should be non-greedy.

@benjamine
Copy link
Author

hi, almost forgot about this, are there any blockers?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@benjamine @bkeepers @technicalpickles @beneidel