Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs for sdpa_kernel #35410

Merged
merged 2 commits into from
Dec 30, 2024
Merged

Update docs for sdpa_kernel #35410

merged 2 commits into from
Dec 30, 2024

Conversation

jla524
Copy link
Contributor

@jla524 jla524 commented Dec 24, 2024

What does this PR do?

Addresses #34411 (issue)

Replace torch.backends.cuda.sdp_kernel (deprecated) with torch.nn.attention.sdpa_kernel

Who can review?

@stevhliu

stevhliu
stevhliu approved these changes Dec 30, 2024
View reviewed changes
Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating!

@stevhliu stevhliu merged commit b5f9797 into huggingface:main Dec 30, 2024
8 checks passed
@jla524 jla524 deleted the docs/update_sdpa_attn branch December 30, 2024 20:17
@jla524 jla524 mentioned this pull request Dec 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevhliu stevhliu stevhliu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jla524 @stevhliu